Skip to content

Commit 2f922e2

Browse files
j-gaocopybara-github
authored andcommitted
Internal change
PiperOrigin-RevId: 838713400
1 parent cb13858 commit 2f922e2

File tree

6 files changed

+16
-2
lines changed

6 files changed

+16
-2
lines changed

src/java/com/google/devtools/mobileharness/infra/ats/common/BUILD

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,7 @@ java_library(
191191
"//src/devtools/mobileharness/infra/ats/common/proto:xts_common_java_proto",
192192
"//src/devtools/mobileharness/infra/ats/server/proto:service_java_proto",
193193
"//src/devtools/mobileharness/platform/android/xts/proto:configuration_java_proto",
194+
"//src/java/com/google/devtools/mobileharness/platform/android/xts/suite:test_suite_helper",
194195
"//src/java/com/google/devtools/mobileharness/platform/android/xts/suite:test_suite_info",
195196
"//src/java/com/google/devtools/mobileharness/platform/android/xts/suite/retry:retry_type",
196197
"//src/java/com/google/devtools/mobileharness/shared/util/auto:auto_value",

src/java/com/google/devtools/mobileharness/infra/ats/common/SessionRequestHandlerUtil.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -705,7 +705,7 @@ public SessionRequestInfo addNonTradefedModuleInfo(SessionRequestInfo sessionReq
705705
getTestSuiteHelper(xtsRootDir.toString(), xtsType, sessionRequestInfo);
706706
updatedSessionRequestInfo.setExpandedModules(
707707
ImmutableMap.copyOf(
708-
testSuiteHelper.loadTests(getDeviceInfo(sessionRequestInfo).orElse(null))));
708+
testSuiteHelper.loadTests(sessionRequestInfo.deviceInfo().orElse(null))));
709709

710710
ImmutableList<String> modules = sessionRequestInfo.moduleNames();
711711
ImmutableSet<String> allNonTfModules = getNonTfModules(configsMap);
@@ -719,7 +719,7 @@ public static boolean shouldEnableModuleSharding(SessionRequestInfo sessionReque
719719
&& !SessionRequestHandlerUtil.isRunRetry(sessionRequestInfo.testPlan());
720720
}
721721

722-
private Optional<DeviceInfo> getDeviceInfo(SessionRequestInfo sessionRequestInfo)
722+
public Optional<DeviceInfo> getDeviceInfo(SessionRequestInfo sessionRequestInfo)
723723
throws MobileHarnessException, InterruptedException {
724724
Optional<DeviceInfo> deviceInfo =
725725
Flags.instance().enableAtsMode.getNonNull()

src/java/com/google/devtools/mobileharness/infra/ats/common/SessionRequestInfo.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import com.google.devtools.mobileharness.infra.ats.server.proto.ServiceProto.TestEnvironment;
2727
import com.google.devtools.mobileharness.infra.ats.server.proto.ServiceProto.TestResource;
2828
import com.google.devtools.mobileharness.platform.android.xts.config.proto.ConfigurationProto.Configuration;
29+
import com.google.devtools.mobileharness.platform.android.xts.suite.TestSuiteHelper.DeviceInfo;
2930
import com.google.devtools.mobileharness.platform.android.xts.suite.TestSuiteInfo;
3031
import com.google.devtools.mobileharness.platform.android.xts.suite.retry.RetryType;
3132
import java.time.Duration;
@@ -51,6 +52,8 @@ public abstract class SessionRequestInfo {
5152

5253
public abstract ImmutableList<String> deviceSerials();
5354

55+
public abstract Optional<DeviceInfo> deviceInfo();
56+
5457
public abstract ImmutableList<String> excludeDeviceSerials();
5558

5659
public abstract ImmutableList<String> productTypes();
@@ -107,6 +110,7 @@ public abstract class SessionRequestInfo {
107110
/** Key is config file absolute path. */
108111
public abstract ImmutableMap<String, Configuration> v2ConfigsMap();
109112

113+
/** Key is expanded module name (e.g. `arm64-v8a CtsBatteryHealthTestCases`). */
110114
public abstract ImmutableMap<String, Configuration> expandedModules();
111115

112116
public abstract boolean enableModuleParameter();
@@ -173,6 +177,7 @@ public static Builder builder() {
173177
return new AutoValue_SessionRequestInfo.Builder()
174178
.setModuleNames(ImmutableList.of())
175179
.setDeviceSerials(ImmutableList.of())
180+
.setDeviceInfo(Optional.empty())
176181
.setExcludeDeviceSerials(ImmutableList.of())
177182
.setProductTypes(ImmutableList.of())
178183
.setDeviceProperties(ImmutableMap.of())
@@ -216,6 +221,8 @@ public abstract static class Builder {
216221

217222
public abstract Builder setExcludeDeviceSerials(List<String> excludeDeviceSerials);
218223

224+
public abstract Builder setDeviceInfo(Optional<DeviceInfo> deviceInfo);
225+
219226
public abstract Builder setProductTypes(List<String> productTypes);
220227

221228
public abstract Builder setDeviceProperties(ImmutableMap<String, String> deviceProperties);

src/java/com/google/devtools/mobileharness/infra/ats/console/controller/sessionplugin/BUILD

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,7 @@ java_library(
196196
"//src/java/com/google/devtools/mobileharness/infra/client/longrunningservice/model:session_info",
197197
"//src/java/com/google/devtools/mobileharness/platform/android/xts/common/util:xts_constants",
198198
"//src/java/com/google/devtools/mobileharness/platform/android/xts/common/util:xts_dir_util",
199+
"//src/java/com/google/devtools/mobileharness/platform/android/xts/suite:test_suite_helper",
199200
"//src/java/com/google/devtools/mobileharness/platform/android/xts/suite:test_suite_info_provider",
200201
"//src/java/com/google/devtools/mobileharness/platform/android/xts/suite/retry:retry_type",
201202
"//src/java/com/google/devtools/mobileharness/shared/constant:log_record_importance",

src/java/com/google/devtools/mobileharness/infra/ats/console/controller/sessionplugin/RunCommandHandler.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@
5151
import com.google.devtools.mobileharness.infra.client.longrunningservice.model.SessionInfo;
5252
import com.google.devtools.mobileharness.platform.android.xts.common.util.XtsConstants;
5353
import com.google.devtools.mobileharness.platform.android.xts.common.util.XtsDirUtil;
54+
import com.google.devtools.mobileharness.platform.android.xts.suite.TestSuiteHelper.DeviceInfo;
5455
import com.google.devtools.mobileharness.platform.android.xts.suite.TestSuiteInfoProvider;
5556
import com.google.devtools.mobileharness.platform.android.xts.suite.retry.RetryType;
5657
import com.google.devtools.mobileharness.shared.util.file.local.LocalFileUtil;
@@ -417,6 +418,9 @@ SessionRequestInfo generateSessionRequestInfo(RunCommand runCommand)
417418
sessionInfo
418419
.getSessionProperty(SessionProperties.PROPERTY_KEY_SESSION_CLIENT_ID)
419420
.ifPresent(builder::setSessionClientId);
421+
422+
Optional<DeviceInfo> deviceInfo = sessionRequestHandlerUtil.getDeviceInfo(builder.build());
423+
builder.setDeviceInfo(deviceInfo);
420424
return sessionRequestHandlerUtil.addNonTradefedModuleInfo(builder.build());
421425
}
422426
}

src/java/com/google/devtools/mobileharness/infra/ats/server/sessionplugin/NewMultiCommandRequestHandler.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -598,6 +598,7 @@ private SessionRequestInfo generateSessionRequestInfo(
598598
}
599599

600600
return sessionRequestInfoBuilder
601+
.setDeviceInfo(sessionRequestHandlerUtil.getDeviceInfo(sessionRequestInfoBuilder.build()))
601602
.setAtsServerTestResources(fileTestResources.build())
602603
.setAtsServerTestEnvironment(request.getTestEnvironment())
603604
.build();

0 commit comments

Comments
 (0)