-
Notifications
You must be signed in to change notification settings - Fork 607
Add resumable download support via range requests #2144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This is important, it is getting common for people to put AI models in layers. They can be many GBs in size increasing the chances of interrupted downloads being problematic. |
|
HI @brandonmichigangithub @Subserial I'd appreciate it if you could take a look at this PR when you have a moment. As mentioned, resumable downloads are becoming increasingly important for large container layers, like those used for AI models, where download interruptions are more likely. I've also noticed that the PR queue is quite long and the merge velocity seems low. I completely understand this is common for popular and busy projects. This got me thinking about the project's long-term bandwidth. Has the team considered adding more co-maintainers from the community to help manage the backlog of issues and PRs? There are likely several people (myself included) who would be willing to step up, share the load, and help keep the project moving. Thanks for your time and for maintaining this project! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2144 +/- ##
===========================================
- Coverage 71.67% 52.98% -18.70%
===========================================
Files 123 165 +42
Lines 9935 10987 +1052
===========================================
- Hits 7121 5821 -1300
- Misses 2115 4455 +2340
- Partials 699 711 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
So we can resume pulls Signed-off-by: Eric Curtin <[email protected]>
9cd0eb4 to
d396c2a
Compare
|
@brandonmichigangithub @Subserial can this be reviewed please? We are forking this library to add this in Docker Model Runner, hoping it's a short term fork: |
|
@brandonmichigangithub @Subserial have you got cycles to look at this? We already shipped it in Docker Model Runner |
So we can resume pulls