From 7cee581c922f607b4c1ac2253385c9ec783f02fb Mon Sep 17 00:00:00 2001 From: bajajnehaa Date: Thu, 30 Jul 2026 09:12:48 +0000 Subject: [PATCH] fix(storage): EnrichSpan in ResumeAppendableUpload should have bucket name from append_object_spec rather than write_object_spec --- google/cloud/storage/internal/async/connection_tracing.cc | 3 +-- .../cloud/storage/internal/async/connection_tracing_test.cc | 5 ++++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/google/cloud/storage/internal/async/connection_tracing.cc b/google/cloud/storage/internal/async/connection_tracing.cc index adb73beb86269..06c4e44772709 100644 --- a/google/cloud/storage/internal/async/connection_tracing.cc +++ b/google/cloud/storage/internal/async/connection_tracing.cc @@ -125,8 +125,7 @@ class AsyncConnectionTracing : public storage::AsyncConnection { ResumeAppendableObjectUpload(AppendableUploadParams p) override { auto span = internal::MakeSpan( "storage::AsyncConnection::ResumeAppendableObjectUpload"); - EnrichSpan(*span, p.options, - p.request.write_object_spec().resource().bucket()); + EnrichSpan(*span, p.options, p.request.append_object_spec().bucket()); internal::OTelScope scope(span); return impl_->ResumeAppendableObjectUpload(std::move(p)) .then([oc = opentelemetry::context::RuntimeContext::GetCurrent(), diff --git a/google/cloud/storage/internal/async/connection_tracing_test.cc b/google/cloud/storage/internal/async/connection_tracing_test.cc index f793243f42c05..3abfff870f5d0 100644 --- a/google/cloud/storage/internal/async/connection_tracing_test.cc +++ b/google/cloud/storage/internal/async/connection_tracing_test.cc @@ -667,9 +667,12 @@ TEST(ConnectionTracing, ResumeAppendableObjectUploadSuccess) { EXPECT_CALL(*mock, ResumeAppendableObjectUpload).WillOnce(expect_context(p)); auto actual = MakeTracingAsyncConnection(std::move(mock)); + google::storage::v2::BidiWriteObjectRequest request; + request.mutable_append_object_spec()->set_bucket("test-bucket"); auto f = actual ->ResumeAppendableObjectUpload( - AsyncConnection::AppendableUploadParams{}) + AsyncConnection::AppendableUploadParams{request, + TracingEnabled()}) .then(expect_no_context); auto mock_writer = std::make_unique();