Skip to content

Instructions to preview pull request need update #343

@ElsLommelen

Description

@ElsLommelen

While reviewing a PR, I followed the instructions to preview the updated website in the PR itself (that are added to PR by default), but I was not able to download and launch the Google Chrome Web Server app as it can apparently only run on Chrome OS:

image

I did this several times in the past, and it used to work, but it seems that they changed their product in a way that it is not available anymore to use in a simple Chrome browser on a computer. So I tried the other option with the python command, but as expected, a default INBO computer doesn't have python installed. Installing python just to review a PR is a lot of work, so I'm afraid that providing this preview is a waste of resources as reviewers won't use it if it there is no easy way to view it.

Could the instructions be updated, at least to prevent others from trying it without success? And if no easy method could be found to view the preview, it might be considered to not waste resources to make it anyway. (It is moreover frustrating as a reviewer to know that there is a preview, but it cannot be viewed.)

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions