refactor(docs): remove deprecation warning from legacy icons, since they are all deprecated

Author: balzss

packages/ui-icons/icons.config.cjs

@@ -45,42 +45,6 @@ const react = {
   componentBaseName: 'Icon'
 }
 
-const deprecated = {
-  /* [icon name]: [icon name to use instead]
-  /* e.g. 'arrow-up': 'arrow' */
-  'discussion-x': 'x',
-  'copy-course': 'copy',
-  'discussion-reply-dark': 'more',
-  'discussion-reply': 'more',
-  'discussion-search': 'search',
-  'search-address-book': 'search',
-  'rss-add': 'add',
-  'user-add': 'add',
-  'materials-required-light': 'materials-required',
-  'mature-light': 'mature',
-  'note-dark': 'note',
-  'note-light': 'note',
-  'icon-reply-2': 'icon-reply',
-  'icon-replied': 'icon-reply',
-  instructure: 'instructure-logo',
-  'settings-2': 'settings',
-  'twitter-boxed': 'twitter',
-  'arrow-left': 'arrow-start',
-  'arrow-open-left': 'arrow-open-start',
-  'arrow-open-right': 'arrow-open-end',
-  'arrow-right': 'arrow-end',
-  'expand-left': 'expand-start',
-  'mini-arrow-left': 'mini-arrow-start',
-  'mini-arrow-right': 'mini-arrow-end',
-  'move-left': 'move-start',
-  'move-right': 'move-end',
-  'text-left': 'text-start',
-  'text-right': 'text-end',
-  'toggle-left': 'toggle-start',
-  'toggle-right': 'toggle-end',
-  unpublish: 'unpublished'
-}
-
 const bidirectional = [
   'address-book',
   'annotate',
@@ -171,6 +135,5 @@ module.exports = {
   svg,
   fonts,
   react,
-  deprecated,
   bidirectional
 }

packages/ui-scripts/lib/icons/build-icons.js

@@ -94,15 +94,14 @@ export default {
 
     const glyphs = getGlyphData(
       svgSourceDir,
-      config.deprecated,
       config.bidirectional,
       config.react.componentBaseName
     )
 
     // generate svg index
     generateSvgIndex(glyphs, config.destination)
     //    - output: ui-icons/src/generated/svg/index.js
-    //    - fields: variant, glyphName, src (svg), deprecated
+    //    - fields: variant, glyphName, src (svg)
 
     // generate react components
     generateReactComponents(glyphs, config.destination)

packages/ui-scripts/lib/icons/generate-legacy-icons-data.js

@@ -26,30 +26,25 @@ import getGlyphData from './get-glyph-data.js'
 
 export default function generateLegacyIconsData() {
   const svgDir = path.join(process.cwd(), 'svg/')
-  const deprecatedMap = {}
   const bidirectionalList = []
 
   const glyphsRaw = getGlyphData(
     svgDir,
-    deprecatedMap,
     bidirectionalList,
     'Icon'
   )
 
   // Group by glyphName to merge Line and Solid variants
   return Object.values(
     glyphsRaw.reduce(
-      (acc, { name, glyphName, variant, src, bidirectional, deprecated }) => {
-        if (!deprecated) {
-          const existing = acc[glyphName] || { name, glyphName, bidirectional }
-          const updated = { ...existing }
+      (acc, { name, glyphName, variant, src, bidirectional }) => {
+        const existing = acc[glyphName] || { name, glyphName, bidirectional }
+        const updated = { ...existing }
 
-          if (variant === 'Line') updated.lineSrc = src
-          if (variant === 'Solid') updated.solidSrc = src
+        if (variant === 'Line') updated.lineSrc = src
+        if (variant === 'Solid') updated.solidSrc = src
 
-          return { ...acc, [glyphName]: updated }
-        }
-        return acc
+        return { ...acc, [glyphName]: updated }
       },
       {}
     )

packages/ui-scripts/lib/icons/generate-react-components.js

@@ -50,7 +50,7 @@ const NOTICE_HEADER = `/*
 `
 
 async function generateIconComponent(glyph) {
-  const { name, variant, glyphName, deprecated, bidirectional, src } = glyph
+  const { name, variant, glyphName, bidirectional, src } = glyph
 
   const source = src.match(
     /<svg\b[^>]*?(?:viewBox="(\b[^"]*)")?>([\s\S]*?)<\/svg>/
@@ -66,7 +66,6 @@ class ${name}${variant} extends Component<SVGIconProps> {
   static glyphName = '${glyphName}'
   static variant = '${variant}'
   static displayName = '${name}${variant}'
-  ${deprecated ? `static deprecated = true` : ''}
   static allowedProps: Array<string> = [ ...SVGIcon.allowedProps ]
 
   ref: Element | null = null
@@ -82,13 +81,6 @@ class ${name}${variant} extends Component<SVGIconProps> {
   }
 
   render () {
-    ${
-      deprecated
-        ? `if (process.env.NODE_ENV !== 'production') {
-      console.warn('<${name}${variant} /> is deprecated. Please use <${deprecated}${variant} /> instead.')
-    }`
-        : ''
-    }
     return (
       <SVGIcon
         {...this.props}

packages/ui-scripts/lib/icons/generate-svg-index.js

@@ -54,8 +54,7 @@ export default function generateSvgIndex(glyphs, destination) {
       return `export const ${glyph.name}${glyph.variant} = {
   variant: "${glyph.variant}",
   glyphName: "${glyph.glyphName}",
-  src: \`${glyph.src}\`,
-  deprecated: ${!!glyph.deprecated}
+  src: \`${glyph.src}\`
 }`
     })
     .join('\n\n')

packages/ui-scripts/lib/icons/get-glyph-data.js

@@ -32,7 +32,6 @@ function toPascalCase(text) {
 
 export default function getGlyphData(
   svgSourceDir,
-  deprecatedMap,
   bidirectionalList,
   prefix
 ) {
@@ -57,8 +56,7 @@ export default function getGlyphData(
         glyphName: name,
         variant: subdir,
         src: fileContent,
-        bidirectional: bidirectionalList.includes(name),
-        deprecated: deprecatedMap[name] ?? false
+        bidirectional: bidirectionalList.includes(name)
       })
     })
   })