Fix error handling (#668)

rustycl0ck · web-flow · commit ec33896b37a3 · 2021-01-22T17:42:27.000-05:00
Do not silently proceed further on receiving an error response.

Signed-off-by: rustyclock &lt;rustyclock@protonmail.com&gt;
diff --git a/github/config.go b/github/config.go
@@ -115,6 +115,8 @@ func (c *Config) ConfigureOwner(owner *Owner) (*Owner, error) {
 				owner.id = remoteOrg.GetID()
 				owner.IsOrganization = true
 			}
+		} else {
+			return nil, err
 		}
 	}
 
@@ -210,6 +212,8 @@ func (c *Config) Clients() (interface{}, error) {
 				owner.id = remoteOrg.GetID()
 				owner.IsOrganization = true
 			}
+		} else {
+			return nil, err
 		}
 	}
 	return &owner, nil

Original file line number	Diff line number	Diff line change
`@@ -115,6 +115,8 @@ func (c Config) ConfigureOwner(owner Owner) (*Owner, error) {`
`115`	`115`	`owner.id = remoteOrg.GetID()`
`116`	`116`	`owner.IsOrganization = true`
`117`	`117`	`}`
	`118`	`+ } else {`
	`119`	`+ return nil, err`
`118`	`120`	`}`
`119`	`121`	`}`
`120`	`122`
`@@ -210,6 +212,8 @@ func (c *Config) Clients() (interface{}, error) {`
`210`	`212`	`owner.id = remoteOrg.GetID()`
`211`	`213`	`owner.IsOrganization = true`
`212`	`214`	`}`
	`215`	`+ } else {`
	`216`	`+ return nil, err`
`213`	`217`	`}`
`214`	`218`	`}`
`215`	`219`	`return &owner, nil`