Merge pull request #141 from krocard/functional-test-rebirth

Functional test rebirth

Start from scratch a new functional test suite.
This new test framework:
     - wrap all PF calls that can fail in order to throw exception
       (automatic failure detection)
     - wrap the PF for a more user friendly api (less boilerplate)
     - permit to generate temporary custom xml config file.

Current implemented functional tests (see test plan for details):
      - Default logger
      - No logger
      - Logger should receive info and warnings
      - Unset logger
      - Wrong plugin
      - Settings OK
      - Wrong settings
      - Wrong settings but ignore
      - invalid top level config file
      - invalid structure
      - invalid settings

Author: krocard

bindings/python/pfw.i

@@ -95,9 +95,11 @@ public:
     bool getFailureOnMissingSubsystem() const;
 
     void setFailureOnFailedSettingsLoad(bool bFail);
-    bool getFailureOnFailedSettingsLoad();
+    bool getFailureOnFailedSettingsLoad() const;
 
     void setSchemaFolderLocation(const std::string& strSchemaFolderLocation);
+    const std::string& getSchemaFolderLocation() const;
+
     void setValidateSchemasOnStart(bool bValidate);
     bool getValidateSchemasOnStart() const;
 

ctest/CTestCustom.cmake

@@ -3,5 +3,5 @@ SET(CTEST_CUSTOM_MEMCHECK_IGNORE
   # Python generates too many valgrind errors,
   # runing python based tests would be long and useless.
   fix_point_parameter
-  functional-test
+  functional-test-legacy
   )

parameter/ParameterMgr.cpp

@@ -620,7 +620,7 @@ bool CParameterMgr::loadSettings(string& strError)
     if (!success && !_bFailOnFailedSettingsLoad) {
         // Load can not fail, ie continue but log the load errors
         log_info("%s", strLoadError.c_str());
-        log_info("Failed to load settings, continue without domains.");
+        log_warning("Failed to load settings, continue without domains.");
         success = true;
     }
 
@@ -855,7 +855,7 @@ void CParameterMgr::setFailureOnFailedSettingsLoad(bool bFail)
     _bFailOnFailedSettingsLoad = bFail;
 }
 
-bool CParameterMgr::getFailureOnFailedSettingsLoad()
+bool CParameterMgr::getFailureOnFailedSettingsLoad() const
 {
     return _bFailOnFailedSettingsLoad;
 }

parameter/ParameterMgr.h

@@ -177,7 +177,7 @@ class CParameterMgr : private CElement
       *
       * @return failure on failed settings load policy state.
       */
-    bool getFailureOnFailedSettingsLoad();
+    bool getFailureOnFailedSettingsLoad() const;
 
     /** Get the path to the directory containing the XML Schemas
      *

parameter/ParameterMgrFullConnector.cpp

@@ -125,7 +125,7 @@ void CParameterMgrFullConnector::setFailureOnFailedSettingsLoad(bool bFail)
     _pParameterMgr->setFailureOnFailedSettingsLoad(bFail);
 }
 
-bool CParameterMgrFullConnector::getFailureOnFailedSettingsLoad()
+bool CParameterMgrFullConnector::getFailureOnFailedSettingsLoad() const
 {
     return _pParameterMgr->getFailureOnFailedSettingsLoad();
 }

parameter/ParameterMgrPlatformConnector.cpp

@@ -115,7 +115,7 @@ bool CParameterMgrPlatformConnector::setFailureOnMissingSubsystem(bool bFail, st
     return true;
 }
 
-bool CParameterMgrPlatformConnector::getFailureOnMissingSubsystem()
+bool CParameterMgrPlatformConnector::getFailureOnMissingSubsystem() const
 {
     return _pParameterMgr->getFailureOnMissingSubsystem();
 }
@@ -133,7 +133,7 @@ bool CParameterMgrPlatformConnector::setFailureOnFailedSettingsLoad(
     return true;
 }
 
-bool CParameterMgrPlatformConnector::getFailureOnFailedSettingsLoad()
+bool CParameterMgrPlatformConnector::getFailureOnFailedSettingsLoad() const
 {
     return _pParameterMgr->getFailureOnFailedSettingsLoad();
 }
@@ -161,7 +161,7 @@ bool CParameterMgrPlatformConnector::setValidateSchemasOnStart(
     return true;
 }
 
-bool CParameterMgrPlatformConnector::getValidateSchemasOnStart()
+bool CParameterMgrPlatformConnector::getValidateSchemasOnStart() const
 {
     return _pParameterMgr->getValidateSchemasOnStart();
 }

parameter/SystemClass.cpp

@@ -255,6 +255,8 @@ bool CSystemClass::loadPlugins(list<string>& lstrPluginFiles, list<string>& lstr
 
             lstrError.push_back("Subsystem plugin " + strPluginFileName +
                                 " does not contain " + strPluginSymbol + " symbol.");
+            // Next plugin
+            ++it;
 
             continue;
         }

parameter/include/ParameterMgrFullConnector.h

@@ -109,7 +109,7 @@ class CParameterMgrFullConnector
       *
       * @return failure on failed settings load policy state.
       */
-    bool getFailureOnFailedSettingsLoad();
+    bool getFailureOnFailedSettingsLoad() const;
 
     /** Get the path to the directory containing the XML Schemas
      *

parameter/include/ParameterMgrPlatformConnector.h

@@ -108,7 +108,7 @@ class CParameterMgrPlatformConnector
       *
       * @return if the subsystem load will fail on missing subsystem.
       */
-    bool getFailureOnMissingSubsystem();
+    bool getFailureOnMissingSubsystem() const;
 
     /** Should start fail in failed settings load.
       *
@@ -125,7 +125,7 @@ class CParameterMgrPlatformConnector
       *
       * @return failure on failed settings load policy state.
       */
-    bool getFailureOnFailedSettingsLoad();
+    bool getFailureOnFailedSettingsLoad() const;
 
     /** Get the path to the directory containing the XML Schemas
      *
@@ -154,7 +154,7 @@ class CParameterMgrPlatformConnector
      *
      * @return areSchemasValidated
      */
-    bool getValidateSchemasOnStart();
+    bool getValidateSchemasOnStart() const;
 
 private:
     CParameterMgrPlatformConnector(const CParameterMgrPlatformConnector&);

test/CMakeLists.txt

@@ -29,5 +29,6 @@
 add_subdirectory(test-platform)
 add_subdirectory(test-fixed-point-parameter)
 add_subdirectory(tokenizer)
+add_subdirectory(functional-tests-legacy)
 add_subdirectory(functional-tests)
 add_subdirectory(test-subsystem)