fixing the feature that removes unwanted discontinuities at t=0 so that it works when a model is initialised from a previous state

isaacbasil · isaacbasil · commit a354bc0c6481 · 2025-06-24T18:56:38.000+02:00
diff --git a/src/pybamm/solvers/base_solver.py b/src/pybamm/solvers/base_solver.py
@@ -978,7 +978,7 @@ def _get_discontinuity_start_end_indices(model, inputs, t_eval):
                 i == len(discontinuities) - 1
                 or discontinuities[i] < discontinuities[i + 1]
             )
-            and v > 0
+            and v > t_eval[0]
         ]
 
         # remove any discontinuities after end of t_eval

Original file line number	Diff line number	Diff line change
`@@ -978,7 +978,7 @@ def _get_discontinuity_start_end_indices(model, inputs, t_eval):`
`978`	`978`	`i == len(discontinuities) - 1`
`979`	`979`	`or discontinuities[i] < discontinuities[i + 1]`
`980`	`980`	`)`
`981`		`- and v > 0`
	`981`	`+ and v > t_eval[0]`
`982`	`982`	`]`
`983`	`983`
`984`	`984`	`# remove any discontinuities after end of t_eval`