Skip to content

Fix PointLight infinite radius shader overflow(#2566) #2570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yaRnMcDonuts merged 3 commits into from
Jan 26, 2026
Merged

Fix PointLight infinite radius shader overflow(#2566) #2570

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6157277
Fix PointLight infinite radius shader overflow(#2566)
hayden9329 Dec 1, 2025
d1a2703
Address Requested Changed from Codex
yaRnMcDonuts Jan 21, 2026
33bd955
Update PointLight.java
yaRnMcDonuts Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions jme3-core/src/main/java/com/jme3/light/PointLight.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,12 @@ public final void setRadius(float radius) {
if (radius < 0) {
throw new IllegalArgumentException("Light radius cannot be negative");
}

if (radius == Float.POSITIVE_INFINITY) {
radius = Float.MAX_VALUE;
if(Float.isNaN(radius)){
throw new IllegalArgumentException("Light radius cannot be a NaN (Not a Number) value");
}

float maxSafeRadius = Float.MAX_VALUE / 4.0f;
radius = Math.min(radius, maxSafeRadius); // Caps radius to a safe large value; avoids overflow in shaders from values reaching max float value

this.radius = radius;
if (radius != 0f) {
Expand Down Expand Up @@ -259,3 +261,5 @@ public String toString() {
+ "]";
}
}