Merge pull request #703 from bckohan/master

Test abstract base model custom manager specification

Author: bckohan

src/polymorphic/tests/migrations/0001_initial.py

@@ -1,4 +1,4 @@
-# Generated by Django 4.2.27 on 2025-12-10 14:11
+# Generated by Django 4.2.27 on 2025-12-10 17:20
 
 from django.conf import settings
 from django.db import migrations, models
@@ -68,6 +68,21 @@ class Migration(migrations.Migration):
             },
             bases=(polymorphic.showfields.ShowFieldTypeAndContent, models.Model),
         ),
+        migrations.CreateModel(
+            name='DerivedManagerTest',
+            fields=[
+                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
+                ('abstract_field', models.CharField(max_length=32)),
+                ('polymorphic_ctype', models.ForeignKey(editable=False, null=True, on_delete=django.db.models.deletion.CASCADE, related_name='polymorphic_%(app_label)s.%(class)s_set+', to='contenttypes.contenttype')),
+            ],
+            options={
+                'abstract': False,
+            },
+            managers=[
+                ('basic_manager', django.db.models.manager.Manager()),
+                ('objects', django.db.models.manager.Manager()),
+            ],
+        ),
         migrations.CreateModel(
             name='Duck',
             fields=[
@@ -373,6 +388,16 @@ class Migration(migrations.Migration):
             },
             bases=('tests.custompkbase',),
         ),
+        migrations.CreateModel(
+            name='DerivedManagerTest2',
+            fields=[
+                ('derivedmanagertest_ptr', models.OneToOneField(auto_created=True, on_delete=django.db.models.deletion.CASCADE, parent_link=True, primary_key=True, serialize=False, to='tests.derivedmanagertest')),
+            ],
+            options={
+                'abstract': False,
+            },
+            bases=('tests.derivedmanagertest',),
+        ),
         migrations.CreateModel(
             name='Enhance_Inherit',
             fields=[

src/polymorphic/tests/models.py

@@ -4,6 +4,7 @@
 from django.contrib.auth.models import Group
 from django.contrib.auth import get_user_model
 from django.contrib.contenttypes.models import ContentType
+from django.db.models import Manager
 from django.db import models
 from django.db.models.query import QuerySet
 
@@ -645,3 +646,36 @@ class MyChild2Model(MyBaseModel):
     ...
     objects = PolymorphicManager.from_queryset(MyChild2QuerySet)()
     base_manager = MyBaseQuerySet.as_manager()
+
+
+class SpecialQuerySet(PolymorphicQuerySet):
+    def has_text(self, text):
+        return self.filter(abstract_field__icontains=text)
+
+
+class SpecialPolymorphicManager(PolymorphicManager.from_queryset(SpecialQuerySet)):
+    def custom_queryset(self):
+        return self.get_queryset()
+
+
+class AbstractManagerTest(PolymorphicModel):
+    """
+    Tests that custom manager patterns work on abstract base models
+    """
+
+    objects = SpecialPolymorphicManager()
+    basic_manager = Manager()
+    default_manager = PolymorphicManager()
+
+    abstract_field = models.CharField(max_length=32)
+
+    class Meta:
+        abstract = True
+
+
+class DerivedManagerTest(AbstractManagerTest):
+    pass
+
+
+class DerivedManagerTest2(DerivedManagerTest):
+    objects = PolymorphicManager()

src/polymorphic/tests/test_orm.py

@@ -1635,3 +1635,43 @@ def test_manager_override(self):
         assert MyChild2Model._default_manager is MyChild2Model.objects
         MyChild2Model.objects.filter_by_user(6).count() == 0
         MyChild2Model.base_manager.filter_by_user(6).count() == 1
+
+    def test_abstract_managers(self):
+        from django.db.models import Manager
+        from polymorphic.tests.models import (
+            AbstractManagerTest,
+            DerivedManagerTest,
+            DerivedManagerTest2,
+            SpecialPolymorphicManager,
+            SpecialQuerySet,
+        )
+
+        with self.assertRaises(AttributeError):
+            AbstractManagerTest.objects
+        with self.assertRaises(AttributeError):
+            AbstractManagerTest.basic_manager
+        with self.assertRaises(AttributeError):
+            AbstractManagerTest.default_manager
+
+        assert type(DerivedManagerTest.objects) is SpecialPolymorphicManager
+        assert type(DerivedManagerTest.basic_manager) is Manager
+        assert type(DerivedManagerTest.default_manager) is PolymorphicManager
+        assert type(DerivedManagerTest._default_manager) is SpecialPolymorphicManager
+
+        assert type(DerivedManagerTest2.objects) is PolymorphicManager
+        assert type(DerivedManagerTest2.basic_manager) is Manager
+        assert type(DerivedManagerTest2.default_manager) is PolymorphicManager
+        assert type(DerivedManagerTest2._default_manager) is PolymorphicManager
+
+        dmt1 = DerivedManagerTest.objects.create(abstract_field="dmt1")
+        dmt2 = DerivedManagerTest2.objects.create(abstract_field="dmt2")
+
+        assert DerivedManagerTest.objects.has_text("dmt").count() == 2
+        assert dmt1 in DerivedManagerTest.objects.has_text("dmt")
+        assert dmt2 in DerivedManagerTest.objects.has_text("dmt")
+        assert DerivedManagerTest.objects.custom_queryset().has_text("dmt").count() == 2
+
+        assert isinstance(DerivedManagerTest.objects.has_text("dmt"), SpecialQuerySet)
+
+        with self.assertRaises(AttributeError):
+            DerivedManagerTest2.objects.has_text("dmt")