Skip to content

Conversation

@mgs2
Copy link

@mgs2 mgs2 commented Jul 28, 2025

Documentation about RabbitMQ scaler has been updated with information about additional DeliverGetRate, PublishedToDeliveredRatio and ExpectedQueueConsumptionTime trigger modes. Changes have been introduced for upcoming (2.18) version.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Code update: kedacore/keda#6933

…hedToDeliveredRatio modes

Signed-off-by: Wojciech Moczulski <[email protected]>
@mgs2 mgs2 requested a review from a team as a code owner July 28, 2025 15:12
@netlify
Copy link

netlify bot commented Jul 28, 2025

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 9bfeab2
🔍 Latest deploy log https://app.netlify.com/projects/keda/deploys/68ff630db2503f0008b01bdd
😎 Deploy Preview https://deploy-preview-1601--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please omit the 2.17 version, this change will be present on >= 2.18 if merged

@mgs2
Copy link
Author

mgs2 commented Sep 9, 2025

Please omit the 2.17 version, this change will be present on >= 2.18 if merged

Done.

mgs2 added 2 commits September 9, 2025 23:10
Signed-off-by: Wojciech Moczulski <[email protected]>
@mgs2 mgs2 changed the title update RabbitMQ scaler docs with additional DeliverGetRate and PublishedToDeliveredRatio modes update RabbitMQ scaler docs with additional DeliverGetRate, PublishedToDeliveredRatio and ExpectedQueueConsumptionTime trigger modes Sep 9, 2025
@mgs2
Copy link
Author

mgs2 commented Oct 11, 2025

Related to PR kedacore/keda#6933 - code for new RabbitMQ scaler modes itself has been merged and shipped with 2.18 release, but docs retain content from 2.17.

Any chance to review this PR (+ request an update if necessary) and merge it, to keep RabbitMQ scaler docs up to date?

@mgs2 mgs2 requested a review from zroubalik October 11, 2025 20:40
@keda-automation keda-automation requested a review from a team October 13, 2025 09:57
…ust* be set to 1 second

Signed-off-by: Wojciech Moczulski <[email protected]>
@JorTurFer
Copy link
Member

Sorry because I missed this. The feature is already merged as part of v2.18, could you rebase this PR and update also the file in v2.19? (the change has to be in both files)

@mgs2
Copy link
Author

mgs2 commented Oct 27, 2025

Sorry because I missed this. The feature is already merged as part of v2.18, could you rebase this PR and update also the file in v2.19? (the change has to be in both files)

Done. Please, take a look. Any feedback on the content itself is more than welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants