-
Notifications
You must be signed in to change notification settings - Fork 514
update RabbitMQ scaler docs with additional DeliverGetRate, PublishedToDeliveredRatio and ExpectedQueueConsumptionTime trigger modes #1601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…hedToDeliveredRatio modes Signed-off-by: Wojciech Moczulski <[email protected]>
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
zroubalik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please omit the 2.17 version, this change will be present on >= 2.18 if merged
… version Signed-off-by: Wojciech Moczulski <[email protected]>
Signed-off-by: Wojciech Moczulski <[email protected]>
Done. |
Signed-off-by: Wojciech Moczulski <[email protected]>
…cs into feat/rabbitmq-add-new-modes
|
Related to PR kedacore/keda#6933 - code for new RabbitMQ scaler modes itself has been merged and shipped with 2.18 release, but docs retain content from 2.17. Any chance to review this PR (+ request an update if necessary) and merge it, to keep RabbitMQ scaler docs up to date? |
…erval Signed-off-by: Wojciech Moczulski <[email protected]>
…ust* be set to 1 second Signed-off-by: Wojciech Moczulski <[email protected]>
|
Sorry because I missed this. The feature is already merged as part of v2.18, could you rebase this PR and update also the file in v2.19? (the change has to be in both files) |
… version Signed-off-by: Wojciech Moczulski <[email protected]>
Done. Please, take a look. Any feedback on the content itself is more than welcome! |
Documentation about RabbitMQ scaler has been updated with information about additional
DeliverGetRate,PublishedToDeliveredRatioandExpectedQueueConsumptionTimetrigger modes. Changes have been introduced for upcoming (2.18) version.Checklist
Code update: kedacore/keda#6933