Use an image which exposes metrics in "Getting Started" tutorial #1625
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the "Getting Started" tutorial, uses the
hashicorp/http-echowhich doesn't expose any metrics (like the later usedhttp_requests_total) and relies on the metrics from the LoadBalancer. Users which go through this tutorial might not have to a LoadBalancer exposing those metrics, which results in the pods not getting scaled as expected.This PR addresses it and uses an image (stefanprodan/podinfo), which exposes metrics (like the
http_requests_total) which can get scraped by prometheus and thus make the scaling work via the http scaler work.Checklist