Skip to content

Support paused-replicas annotation as empty string value #7263

@benjackwhite

Description

@benjackwhite

Proposal

The paused-replicas needs to be an integer otherwise it causes a ScaledObjectCheckFailed. The issue is when using ArgoCD in particular you may want to override this annotation in order to fix the replica scaling and then have it be indicated as "out of sync" by Argo.

This isn't possible if the field is not explicitly defined in the manifest and as null fields don't count, there is no way of supporting this. If we could treat empty string as "no value" then this would enable setting it in git and allowing Argo to notice the diff when changes are manually applied.

An alternative would be to support a value like false to make it more explicit than empty string.

Use-Case

The Argo use case is the big one, but I could imagine there are other CD concepts that use the same idea of diffing manifests to determine if drift has occured.

Is this a feature you are interested in implementing yourself?

Maybe

Anything else?

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Status

    To Triage

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions