Resolving "zsh: no matches found" error when setting Cmd configuration to ["zsh", "-c"]

[justamanpop]

Ran into issues with pet exec when setting default shell to zsh, wanted to show how I fixed it in case it helps someone (don't know the right place to put this, lmk if I should remove it)

To set the shell in which pet runs commands to zsh, I set the Cmd field in the configuraton toml:

[General]
  Backend = "gist"
  Cmd = ["zsh", "-c"]
  Color = false

This, however gave an error when running pet exec:
zsh:1 no matches found --pointer=*

After trying stuff out for a while, I found the issue was with the default SelectCmd:
SelectCmd = "fzf --ansi --layout=reverse --border --height=90% --pointer=* --cycle --prompt=Snippets:"

zsh interprets the * in the command as a glob pattern, and so threw the error.

The fix was to set the noglob option in the SelectCmd:
SelectCmd = "noglob fzf --ansi --layout=reverse --border --height=90% --pointer=* --cycle --prompt=Snippets:"

[RamiAwar]

Thanks for the input @justamanpop ! It's an interesting one, I think maybe this is an overly complicated default SelectCmd.

I personally even have just "fzf" as my SelectCmd and it's pretty amazing as is. I think this should be simplified to prevent others from facing the same issue.

Would you be interested in submitting a PR? It's a pretty simple change! Maybe we can just remove the pointer to begin with, that would fix it right? The default pointer is more than good enough.

[justamanpop]

Hi, sorry for the late response, I could raise a PR, seems like a simple change

But as @tapyu said below, just adding single quotes around the * seems to solve it as well. Up to you if you want to keep the pointer as * or use the default pointer.

[RamiAwar]

I don't mind either, maybe let's preserve current command then and just add quotes!

[tapyu]

I had this exact problem. The solution is to modify the SelectCmd under the General section:

SelectCmd = "fzf --ansi --layout=reverse --border --height=90% --pointer='*' --cycle --select-1 --prompt=Snippets:"

[luisadha]

I think this should be implemented in the custom configuration section by calling

pet configure zsh

this would make more sense. because in bash this error never occurs

[tapyu]

Agreed