Skip to content

Conversation

@konveyor-ci-bot
Copy link

Proxy setting with -Djava...Proxies=true was placed in args after
jar which was most likely ignored by JVM.

Changing its order to ensure its understood correctly by JVM running
jdtls.

Replaces konveyor/java-analyzer-bundle#173

Fixes: konveyor/java-analyzer-bundle#172

Summary by CodeRabbit

  • Bug Fixes
  • Fixed Java application launcher argument ordering to ensure system
    proxy settings are correctly applied before the application runs.

✏️ Tip: You can customize this high-level summary in your review
settings.

Signed-off-by: Marek Aufart [email protected]
Signed-off-by: Cherry Picker [email protected]

Proxy setting with `-Djava...Proxies=true` was placed in args after
`jar` which was most likely ignored by JVM.

Changing its order to ensure its understood correctly by JVM running
jdtls.

Replaces konveyor/java-analyzer-bundle#173

Fixes: konveyor/java-analyzer-bundle#172

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Bug Fixes**
* Fixed Java application launcher argument ordering to ensure system
proxy settings are correctly applied before the application runs.

<sub>✏️ Tip: You can customize this high-level summary in your review
settings.</sub>

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
@coderabbitai
Copy link

coderabbitai bot commented Nov 26, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @eemcmullan is working on getting the ci working for release 0.8. This should be good to go once she does

@aufi aufi closed this Dec 4, 2025
@aufi aufi reopened this Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants