Add book-server app analysis test (#162) (#310)

* Add book-server app analysis test

Adding book-server application analysis test with results verified by
report generated in previous Tackle versions.



* Update book-server witt deps



* Update test tiers



* Update to expect original 6.2 incidents



* Move BookServer back to TIER1



* Update BookServer app from data and comment



* Update Lombok dependency line number



* Update to api.Insight



* Update hub



* Fix deps



* Fix insights field name



---------

Signed-off-by: Marek Aufart <[email protected]>
Co-authored-by: Marek Aufart <[email protected]>

Author: mguetta1

analysis/tc_book-server_verified.go

@@ -0,0 +1,69 @@
+package analysis
+
+import (
+	"github.com/konveyor/go-konveyor-tests/data"
+	"github.com/konveyor/go-konveyor-tests/hack/addon"
+	"github.com/konveyor/tackle2-hub/api"
+)
+
+var BookServerVerified = TC{
+	Name:        "BookServer verified results",
+	Application: data.BookServer,
+	Task:        Analyze,
+	WithDeps:    true,
+	Labels: addon.Labels{
+		Included: []string{
+			"konveyor.io/target=cloud-readiness",
+			"konveyor.io/target=linux",
+			"konveyor.io/target=openjdk21",
+		},
+	},
+	Analysis: api.Analysis{
+		Effort: 9,
+		Issues: []api.Issue{
+			{
+				Category:    "mandatory",
+				Description: "File system - Java IO",
+				Effort:      1,
+				RuleSet:     "cloud-readiness",
+				Rule:        "local-storage-00001",
+				Incidents: []api.Incident{
+					{
+						File:    "/shared/source/book-server/src/main/java/com/telran/application/model/BookModel.java",
+						Line:    14,
+						Message: "An application running inside a container could lose access to a file in local storage.",
+					},
+					{
+						File:    "/shared/source/book-server/src/main/java/com/telran/application/model/BookModel.java",
+						Line:    17,
+						Message: "An application running inside a container could lose access to a file in local storage.",
+					},
+					{
+						File:    "/shared/source/book-server/src/main/java/com/telran/application/model/BookModel.java",
+						Line:    29,
+						Message: "An application running inside a container could lose access to a file in local storage.",
+					},
+					{
+						File:    "/shared/source/book-server/src/main/java/com/telran/application/model/BookModel.java",
+						Line:    32,
+						Message: "An application running inside a container could lose access to a file in local storage.",
+					},
+				},
+			},
+			{
+				Category:    "mandatory",
+				Description: "The Lombok version is incompatible with Open JDK 17",
+				Effort:      3,
+				RuleSet:     "openjdk17/openjdk11",
+				Rule:        "lombok-incompatibility-00001",
+				Incidents: []api.Incident{
+					{
+						File:    "/shared/source/book-server/pom.xml",
+						Line:    31,
+						Message: "Lombok supports Java 17 since version 1.18.22. The version of Lombok used in this project is too old and not compatible with Java 17. You should consider upgrading it.",
+					},
+				},
+			},
+		},
+	},
+}

analysis/test_cases.go

@@ -15,8 +15,10 @@ var Tier0TestCases = []TC{
 // Tier 1 Analysis test cases - should work.
 // List of applications with expected analysis outputs.
 var Tier1TestCases = []TC{
+	BookServerVerified,
 	CoolstoreWithDepsQuarkus,
 	AdministracionEfectivoBinary, // Binary upload
+
 }
 
 // Tier 2 Analysis test cases - great if works.
@@ -26,6 +28,6 @@ var Tier2TestCases = []TC{
 	SeamBooking,
 }
 
-// Tier 3 Analysis with credentials test cases - should work
+// Tier 3 Analysis test cases - should work and should be executed on internal/private infrastructure
 // List of applications with expected analysis outputs.
 var Tier3TestCases = []TC{}