Pod Adoption prioritize ready pods

[peterzhongyi]

Fixes #189

[netlify]

✅ Deploy Preview for agent-sandbox canceled.

Name	Link
🔨 Latest commit	0d60ea8
🔍 Latest deploy log	https://app.netlify.com/projects/agent-sandbox/deploys/692f71ea20925900089121c9

[k8s-ci-robot]

Hi @peterzhongyi. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sdowell]

/ok-to-test

[k8s-ci-robot]

@peterzhongyi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
presubmit-agent-sandbox-e2e-test	0d60ea8	link	true	/test presubmit-agent-sandbox-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[peterzhongyi]

The e2e test failed with

"""
E1202 23:37:52.251125 34010 portforward.go:424] "Unhandled Error" err="an error occurred forwarding 9222 -> 9222: error forwarding port 9222 to pod 437654f386c8b0a3adf64c105f998399187c112eebb4c73431213742644dc8f6, uid : failed to execute portforward in network namespace "/var/run/netns/cni-691305b0-0125-b212-d0f5-c64de7e80775": failed to connect to localhost:9222 inside namespace "437654f386c8b0a3adf64c105f998399187c112eebb4c73431213742644dc8f6", IPv4: dial tcp4 127.0.0.1:9222: connect: connection refused IPv6 dial tcp6 [::1]:9222: connect: connection refused "
"""

This doesn't seem to be related to the code changes in this PR. Is this test failure a known phenomenon?

[sdowell]

The e2e test failed with

""" E1202 23:37:52.251125 34010 portforward.go:424] "Unhandled Error" err="an error occurred forwarding 9222 -> 9222: error forwarding port 9222 to pod 437654f386c8b0a3adf64c105f998399187c112eebb4c73431213742644dc8f6, uid : failed to execute portforward in network namespace "/var/run/netns/cni-691305b0-0125-b212-d0f5-c64de7e80775": failed to connect to localhost:9222 inside namespace "437654f386c8b0a3adf64c105f998399187c112eebb4c73431213742644dc8f6", IPv4: dial tcp4 127.0.0.1:9222: connect: connection refused IPv6 dial tcp6 [::1]:9222: connect: connection refused " """

This doesn't seem to be related to the code changes in this PR. Is this test failure a known phenomenon?

See #199

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aditya-shantanu, peterzhongyi
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment