Skip to content

Conversation

@mbobrovskyi
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Use CreateAdmissionChecksAndWaitForActive.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Dec 4, 2025
@netlify
Copy link

netlify bot commented Dec 4, 2025

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 3430e0f
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/693170501751b300082e6328

@k8s-ci-robot k8s-ci-robot requested review from mimowo and pajakd December 4, 2025 11:28
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 4, 2025
@mbobrovskyi
Copy link
Contributor Author

/cc @mszadkow

@k8s-ci-robot k8s-ci-robot requested a review from mszadkow December 4, 2025 11:53
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/cherrypick release-0.14
/cherrypick release-0.15

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 372b6a0921cf50b1331d85b7a6c2638df4625a80

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2025
@mimowo
Copy link
Contributor

mimowo commented Dec 5, 2025

/test pull-kueue-test-e2e-customconfigs-main
is unrelated flake, because this PR only affects MultiKueue tests

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_kueue/8068/pull-kueue-test-e2e-customconfigs-main/1996555317856440320

@mimowo
Copy link
Contributor

mimowo commented Dec 5, 2025

Known: #5106

@k8s-ci-robot k8s-ci-robot merged commit 33ef84b into kubernetes-sigs:main Dec 5, 2025
28 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.16 milestone Dec 5, 2025
@mbobrovskyi mbobrovskyi deleted the cleanup/use-CreateAdmissionChecksAndWaitToBeActive branch December 5, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants