Commit d4209b7
Add version verification step before npm publish (#257)
* Add version verification step before npm publish
Add a step that checks if the git tag matches the package.json version.
Stops the release if versions don’t match.
Fixes issue #226.
Signed-off-by: Malik Saad Hayat <[email protected]>
* Fix accidental changes to setFailed and restore whitespace.
Thanks for the quick review @viccuad!
You're absolutely right - I accidentally removed a parenthesis and some whitespace. I've just pushed a fix to restore:
- The `(` in `core.setFailed()` on line 41
- The empty lines/spacing throughout the file
The version verification check remains unchanged. Should be good to go now!
Signed-off-by: Malik Saad Hayat <[email protected]>
* Fix accidental changes to setFailed and restore whitespace.
Thanks for the review @viccuad! I've fixed the accidental changes:
- Restored the `(` in `core.setFailed()` on line 41
- Restored the empty lines/whitespace throughout the file
The version verification step remains unchanged. Ready for another look!
Signed-off-by: Malik Saad Hayat <[email protected]>
---------
Signed-off-by: Malik Saad Hayat <[email protected]>
Co-authored-by: Víctor Cuadrado Juan <[email protected]>1 parent e8e13e9 commit d4209b7
1 file changed
+13
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
81 | | - | |
82 | 81 | | |
83 | 82 | | |
84 | | - | |
85 | 83 | | |
86 | 84 | | |
87 | 85 | | |
88 | 86 | | |
89 | | - | |
90 | 87 | | |
91 | 88 | | |
92 | | - | |
93 | 89 | | |
94 | 90 | | |
95 | 91 | | |
| |||
106 | 102 | | |
107 | 103 | | |
108 | 104 | | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
109 | 118 | | |
110 | 119 | | |
111 | 120 | | |
| |||
0 commit comments