Skip to content

Commit a9e71a9

Browse files
committed
Added panic test for res.Failure
Signed-off-by: dhruv0000 <[email protected]>
1 parent 92d8cea commit a9e71a9

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

smi-conformance/grpc/handlers.go

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -98,14 +98,16 @@ func (s *Service) RunTest(ctx context.Context, req *conformance.Request) (*confo
9898

9999
// A hacky way to see the testStep Failed, since KUDO only provides it in Failure.Message
100100
re := regexp.MustCompile(`[0-9]+`)
101-
stepFailed := re.FindAllString(res.Failure.Message, 1)
102-
if len(stepFailed) != 0 {
103-
passed, _ := strconv.Atoi(stepFailed[0])
104-
passed = passed - 1
105-
failures := stepsCount[res.Name] - passed
106-
totalFailures += failures
107-
if (passed) >= (stepsCount[res.Name] / 2) {
108-
d.Capability = conformance.Capability_HALF
101+
if res.Failure != nil {
102+
stepFailed := re.FindAllString(res.Failure.Message, 1)
103+
if len(stepFailed) != 0 {
104+
passed, _ := strconv.Atoi(stepFailed[0])
105+
passed = passed - 1
106+
failures := stepsCount[res.Name] - passed
107+
totalFailures += failures
108+
if (passed) >= (stepsCount[res.Name] / 2) {
109+
d.Capability = conformance.Capability_HALF
110+
}
109111
}
110112
}
111113
}

0 commit comments

Comments
 (0)