Utilize linodego.IsNotFound function to check whether the error is not found error (#2025)

zliang-akamai · web-flow · commit 767576c8d64c · 2025-09-03T15:24:05.000-04:00
diff --git a/linode/databaseaccesscontrols/resource.go b/linode/databaseaccesscontrols/resource.go
@@ -36,7 +36,7 @@ func readResource(ctx context.Context, d *schema.ResourceData, meta interface{})
 
 	allowList, err := getDBAllowListByEngine(ctx, client, dbType, dbID)
 	if err != nil {
-		if lerr, ok := err.(*linodego.Error); ok && lerr.Code == 404 {
+		if linodego.IsNotFound(err) {
 			log.Printf("[WARN] allow_list %q from state because it no longer exists", d.Id())
 			d.SetId("")
 			return nil
diff --git a/linode/databasemysql/resource.go b/linode/databasemysql/resource.go
@@ -50,7 +50,7 @@ func readResource(ctx context.Context, d *schema.ResourceData, meta interface{})
 
 	db, err := client.GetMySQLDatabase(ctx, id)
 	if err != nil {
-		if lerr, ok := err.(*linodego.Error); ok && lerr.Code == 404 {
+		if linodego.IsNotFound(err) {
 			log.Printf("[WARN] removing MySQL database ID %q from state because it no longer exists", d.Id())
 			d.SetId("")
 			return nil
diff --git a/linode/databasemysqlv2/framework_resource.go b/linode/databasemysqlv2/framework_resource.go
@@ -227,7 +227,7 @@ func (r *Resource) Read(
 
 	db, err := client.GetMySQLDatabase(ctx, id)
 	if err != nil {
-		if lerr, ok := err.(*linodego.Error); ok && lerr.Code == 404 {
+		if linodego.IsNotFound(err) {
 			resp.Diagnostics.AddWarning(
 				"Database no longer exists",
 				fmt.Sprintf(
diff --git a/linode/databasepostgresql/resource.go b/linode/databasepostgresql/resource.go
@@ -50,7 +50,7 @@ func readResource(ctx context.Context, d *schema.ResourceData, meta interface{})
 
 	db, err := client.GetPostgresDatabase(ctx, id)
 	if err != nil {
-		if lerr, ok := err.(*linodego.Error); ok && lerr.Code == 404 {
+		if linodego.IsNotFound(err) {
 			log.Printf("[WARN] removing PostgreSQL database ID %q from state because it no longer exists", d.Id())
 			d.SetId("")
 			return nil
diff --git a/linode/databasepostgresqlv2/framework_resource.go b/linode/databasepostgresqlv2/framework_resource.go
@@ -226,7 +226,7 @@ func (r *Resource) Read(
 
 	db, err := client.GetPostgresDatabase(ctx, id)
 	if err != nil {
-		if lerr, ok := err.(*linodego.Error); ok && lerr.Code == 404 {
+		if linodego.IsNotFound(err) {
 			resp.Diagnostics.AddWarning(
 				"Database no longer exists",
 				fmt.Sprintf(
diff --git a/linode/domain/resource.go b/linode/domain/resource.go
@@ -44,7 +44,7 @@ func readResource(ctx context.Context, d *schema.ResourceData, meta interface{})
 
 	domain, err := client.GetDomain(ctx, id)
 	if err != nil {
-		if lerr, ok := err.(*linodego.Error); ok && lerr.Code == 404 {
+		if linodego.IsNotFound(err) {
 			log.Printf("[WARN] removing Linode Domain ID %q from state because it no longer exists", d.Id())
 			d.SetId("")
 			return nil
diff --git a/linode/domainrecord/resource.go b/linode/domainrecord/resource.go
@@ -74,7 +74,7 @@ func readResource(ctx context.Context, d *schema.ResourceData, meta interface{})
 
 	record, err := client.GetDomainRecord(ctx, domainID, id)
 	if err != nil {
-		if lerr, ok := err.(*linodego.Error); ok && lerr.Code == 404 {
+		if linodego.IsNotFound(err) {
 			log.Printf("[WARN] removing Linode Domain Record ID %q from state because it no longer exists", d.Id())
 			d.SetId("")
 			return nil
diff --git a/linode/firewalldevice/framework_resource.go b/linode/firewalldevice/framework_resource.go
@@ -122,7 +122,7 @@ func (r *Resource) Read(
 
 	device, err := client.GetFirewallDevice(ctx, firewallID, id)
 	if err != nil {
-		if lerr, ok := err.(*linodego.Error); ok && lerr.Code == 404 {
+		if linodego.IsNotFound(err) {
 			resp.Diagnostics.AddWarning(
 				"Firewall Device No Longer Exists",
 				fmt.Sprintf(
@@ -213,7 +213,7 @@ func (r *Resource) Delete(
 
 	err := client.DeleteFirewallDevice(ctx, firewallID, id)
 	if err != nil {
-		if lerr, ok := err.(*linodego.Error); ok && lerr.Code == 404 {
+		if linodego.IsNotFound(err) {
 			resp.Diagnostics.AddWarning(
 				fmt.Sprintf(
 					"Attempted to Delete Firewall Device %d But Resource Not Found",
diff --git a/linode/instancedisk/framework_resource.go b/linode/instancedisk/framework_resource.go
@@ -189,7 +189,7 @@ func (r *Resource) Read(
 
 	disk, err := client.GetInstanceDisk(ctx, linodeID, id)
 	if err != nil {
-		if lerr, ok := err.(*linodego.Error); ok && lerr.Code == 404 {
+		if linodego.IsNotFound(err) {
 			resp.Diagnostics.AddWarning(
 				"Disk Not Found",
 				fmt.Sprintf(
diff --git a/linode/instanceip/framework_resource.go b/linode/instanceip/framework_resource.go
@@ -155,7 +155,7 @@ func (r *Resource) Read(
 	}
 	ip, err := client.GetInstanceIPAddress(ctx, linodeID, address)
 	if err != nil {
-		if lerr, ok := err.(*linodego.Error); ok && lerr.Code == 404 {
+		if linodego.IsNotFound(err) {
 			resp.Diagnostics.AddWarning(
 				"Instance IP No Longer Exists",
 				fmt.Sprintf(
diff --git a/linode/instancereservedipassignment/framework_resource.go b/linode/instancereservedipassignment/framework_resource.go
@@ -158,7 +158,7 @@ func (r *Resource) Read(
 
 	ip, err := client.GetIPAddress(ctx, address)
 	if err != nil {
-		if lerr, ok := err.(*linodego.Error); ok && lerr.Code == 404 {
+		if linodego.IsNotFound(err) {
 			resp.Diagnostics.AddWarning(
 				"Reserved IP No Longer Exists",
 				fmt.Sprintf("Removing reserved IP %s from state because it no longer exists", state.ID.ValueString()),
diff --git a/linode/lke/resource.go b/linode/lke/resource.go
@@ -68,7 +68,7 @@ func readResource(ctx context.Context, d *schema.ResourceData, meta interface{})
 
 	cluster, err := client.GetLKECluster(ctx, id)
 	if err != nil {
-		if lerr, ok := err.(*linodego.Error); ok && lerr.Code == 404 {
+		if linodego.IsNotFound(err) {
 			log.Printf("[WARN] removing LKE Cluster ID %q from state because it no longer exists", d.Id())
 			d.SetId("")
 			return nil
@@ -331,7 +331,7 @@ func updateResource(ctx context.Context, d *schema.ResourceData, meta interface{
 
 	cluster, err := client.GetLKECluster(ctx, id)
 	if err != nil {
-		if lerr, ok := err.(*linodego.Error); ok && lerr.Code == 404 {
+		if linodego.IsNotFound(err) {
 			log.Printf("[WARN] removing LKE Cluster ID %q from state because it no longer exists", d.Id())
 			d.SetId("")
 			return nil
@@ -447,7 +447,7 @@ func deleteResource(ctx context.Context, d *schema.ResourceData, meta interface{
 	if err != nil {
 		// If we're getting a 404, it's safe to say the cluster has been
 		// deleted.
-		if lerr, ok := err.(*linodego.Error); ok && lerr.Code == 404 {
+		if linodego.IsNotFound(err) {
 			return nil
 		}
 
diff --git a/linode/lkenodepool/framework_resource.go b/linode/lkenodepool/framework_resource.go
@@ -60,7 +60,7 @@ func (r *Resource) Read(
 
 	nodePool, err := client.GetLKENodePool(ctx, clusterID, poolID)
 	if err != nil {
-		if lerr, ok := err.(*linodego.Error); ok && lerr.Code == 404 {
+		if linodego.IsNotFound(err) {
 			resp.Diagnostics.AddWarning(
 				"Error reading Linode Node Pool",
 				fmt.Sprintf("Removing Linode Node Pool %d in cluster %d, from state because it no longer exists", poolID, clusterID),
@@ -258,7 +258,7 @@ func (r *Resource) Delete(
 	})
 	err := client.DeleteLKENodePool(ctx, clusterID, poolID)
 	if err != nil {
-		if lerr, ok := err.(*linodego.Error); ok && lerr.Code == 404 {
+		if linodego.IsNotFound(err) {
 			resp.Diagnostics.AddWarning(
 				"Node Pool does not exist.",
 				fmt.Sprintf("Node Pool %v does not exist in cluster %v, removing from state.", poolID, clusterID),
diff --git a/linode/nb/framework_resource.go b/linode/nb/framework_resource.go
@@ -148,7 +148,7 @@ func (r *Resource) Read(
 
 	nodeBalancer, err := client.GetNodeBalancer(ctx, id)
 	if err != nil {
-		if lerr, ok := err.(*linodego.Error); ok && lerr.Code == 404 {
+		if linodego.IsNotFound(err) {
 			resp.Diagnostics.AddWarning(
 				"NodeBalancer No Longer Exists",
 				fmt.Sprintf("Removing Linode NodeBalancer ID %v from state because it no longer exists", id),
@@ -299,7 +299,7 @@ func (r *Resource) Delete(
 
 	err := client.DeleteNodeBalancer(ctx, id)
 	if err != nil {
-		if lerr, ok := err.(*linodego.Error); ok && lerr.Code == 404 {
+		if linodego.IsNotFound(err) {
 			resp.Diagnostics.AddWarning(
 				"NodeBalancer No Longer Exists",
 				fmt.Sprintf("NodeBalancer %v does not exist, removing it from state.", id),
diff --git a/linode/networkingipassignment/framework_resource.go b/linode/networkingipassignment/framework_resource.go
@@ -80,7 +80,7 @@ func (r *Resource) Read(ctx context.Context, req resource.ReadRequest, resp *res
 	for i, assignment := range state.Assignments {
 		ip, err := client.GetIPAddress(ctx, assignment.Address.ValueString())
 		if err != nil {
-			if lerr, ok := err.(*linodego.Error); ok && lerr.Code == 404 {
+			if linodego.IsNotFound(err) {
 				// IP not found, remove it from state
 				state.Assignments = append(state.Assignments[:i], state.Assignments[i+1:]...)
 				continue
diff --git a/linode/objbucket/resource.go b/linode/objbucket/resource.go
@@ -64,7 +64,7 @@ func readResource(
 
 	bucket, err := client.GetObjectStorageBucket(ctx, regionOrCluster, label)
 	if err != nil {
-		if lerr, ok := err.(*linodego.Error); ok && lerr.Code == 404 {
+		if linodego.IsNotFound(err) {
 			tflog.Warn(
 				ctx,
 				fmt.Sprintf(
diff --git a/linode/objkey/framework_resource.go b/linode/objkey/framework_resource.go
@@ -106,7 +106,7 @@ func (r *Resource) Read(
 
 	key, err := client.GetObjectStorageKey(ctx, id)
 	if err != nil {
-		if lerr, ok := err.(*linodego.Error); ok && lerr.Code == 404 {
+		if linodego.IsNotFound(err) {
 			resp.Diagnostics.AddWarning(
 				"Object Storage Key",
 				fmt.Sprintf(
diff --git a/linode/rdns/framework_resource.go b/linode/rdns/framework_resource.go
@@ -132,7 +132,7 @@ func (r *Resource) Read(
 
 	ip, err := client.GetIPAddress(ctx, data.ID.ValueString())
 	if err != nil {
-		if lerr, ok := err.(*linodego.Error); ok && lerr.Code == 404 {
+		if linodego.IsNotFound(err) {
 			resp.Diagnostics.AddWarning(
 				"RDNS No Longer Exists",
 				fmt.Sprintf(
@@ -236,7 +236,7 @@ func (r *Resource) Delete(
 	})
 	_, err := client.UpdateIPAddress(ctx, data.Address.ValueString(), updateOpts)
 	if err != nil {
-		if lerr, ok := err.(*linodego.Error); ok && lerr.Code == 404 {
+		if linodego.IsNotFound(err) {
 			resp.Diagnostics.AddWarning(
 				"Target IP for RDNS resetting no longer exists.",
 				fmt.Sprintf(
diff --git a/linode/sshkey/framework_resource.go b/linode/sshkey/framework_resource.go
@@ -99,7 +99,7 @@ func (r *Resource) Read(
 
 	key, err := client.GetSSHKey(ctx, id)
 	if err != nil {
-		if lerr, ok := err.(*linodego.Error); ok && lerr.Code == 404 {
+		if linodego.IsNotFound(err) {
 			resp.Diagnostics.AddWarning(
 				"SSH Key",
 				fmt.Sprintf(
diff --git a/linode/stackscript/framework_resource.go b/linode/stackscript/framework_resource.go
@@ -163,7 +163,7 @@ func (r *Resource) Read(
 
 	stackscript, err := client.GetStackscript(ctx, id)
 	if err != nil {
-		if lerr, ok := err.(*linodego.Error); ok && lerr.Code == 404 {
+		if linodego.IsNotFound(err) {
 			resp.Diagnostics.AddWarning(
 				"StackScript no longer exists.",
 				fmt.Sprintf(
diff --git a/linode/token/framework_resource.go b/linode/token/framework_resource.go
@@ -111,7 +111,7 @@ func (r *Resource) Read(
 
 	token, err := client.GetToken(ctx, id)
 	if err != nil {
-		if lerr, ok := err.(*linodego.Error); ok && lerr.Code == 404 {
+		if linodego.IsNotFound(err) {
 			resp.Diagnostics.AddWarning(
 				"Token No Longer Exists",
 				fmt.Sprintf(
diff --git a/linode/user/resource.go b/linode/user/resource.go
@@ -73,7 +73,7 @@ func readResource(ctx context.Context, d *schema.ResourceData, meta interface{})
 
 	user, err := client.GetUser(ctx, username)
 	if err != nil {
-		if lerr, ok := err.(*linodego.Error); ok && lerr.Code == 404 {
+		if linodego.IsNotFound(err) {
 			log.Printf("[WARN] removing Linode User %q from state because it no longer exists", d.Id())
 			d.SetId("")
 			return nil
diff --git a/linode/volume/framework_resource.go b/linode/volume/framework_resource.go
@@ -336,7 +336,7 @@ func (r *Resource) Read(
 
 	volume, err := client.GetVolume(ctx, id)
 	if err != nil {
-		if lerr, ok := err.(*linodego.Error); ok && lerr.Code == 404 {
+		if linodego.IsNotFound(err) {
 			resp.Diagnostics.AddWarning(
 				"Volume Not Found",
 				fmt.Sprintf("removing Volume ID %d from state because it no longer exists", id),
diff --git a/linode/vpc/framework_resource.go b/linode/vpc/framework_resource.go
@@ -99,7 +99,7 @@ func (r *Resource) Read(
 
 	vpc, err := client.GetVPC(ctx, id)
 	if err != nil {
-		if lerr, ok := err.(*linodego.Error); ok && lerr.Code == 404 {
+		if linodego.IsNotFound(err) {
 			resp.Diagnostics.AddWarning(
 				"VPC no longer exists.",
 				fmt.Sprintf(
diff --git a/linode/vpcsubnet/framework_resource.go b/linode/vpcsubnet/framework_resource.go
@@ -132,7 +132,7 @@ func (r *Resource) Read(
 
 	subnet, err := client.GetVPCSubnet(ctx, vpcId, id)
 	if err != nil {
-		if lerr, ok := err.(*linodego.Error); ok && lerr.Code == 404 {
+		if linodego.IsNotFound(err) {
 			resp.Diagnostics.AddWarning(
 				"VPC subnet does not exist.",
 				fmt.Sprintf(

Original file line number	Diff line number	Diff line change
`@@ -155,7 +155,7 @@ func (r *Resource) Read(`
`155`	`155`	`}`
`156`	`156`	`ip, err := client.GetInstanceIPAddress(ctx, linodeID, address)`
`157`	`157`	`if err != nil {`
`158`		`- if lerr, ok := err.(*linodego.Error); ok && lerr.Code == 404 {`
	`158`	`+ if linodego.IsNotFound(err) {`
`159`	`159`	`resp.Diagnostics.AddWarning(`
`160`	`160`	`"Instance IP No Longer Exists",`
`161`	`161`	`fmt.Sprintf(`