Skip to content

fix: Fix incorrect punctuation#1076

Merged
mhduiy merged 1 commit intolinuxdeepin:masterfrom
leibn123:master
Apr 9, 2026
Merged

fix: Fix incorrect punctuation#1076
mhduiy merged 1 commit intolinuxdeepin:masterfrom
leibn123:master

Conversation

@leibn123
Copy link
Copy Markdown
Contributor

@leibn123 leibn123 commented Apr 1, 2026

fix: Fix incorrect punctuation

1.Fix incorrect punctuation

Summary by Sourcery

Enhancements:

  • Align the authentication prompt for enabling read-only protection with the Solid System Read-Only product name.

@deepin-ci-robot
Copy link
Copy Markdown

Hi @leibn123. Thanks for your PR. 😃

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@deepin-ci-robot
Copy link
Copy Markdown

Hi @leibn123. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Apr 1, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the policy message string for enabling read-only protection to use the new "Solid System Read-Only protection" phrasing and remove trailing punctuation, keeping the rest of the policy configuration unchanged.

File-Level Changes

Change Details Files
Update the user-facing policy message text for enabling read-only protection to reflect new wording and punctuation.
  • Replace the old sentence about enabling read-only protection with the new "Authentication required to enable Solid System Read-Only protection" text
  • Remove the trailing period from the policy message string while keeping translation metadata intact
misc/ts/org.deepin.dde.daemon.system.policy/policy.ts
misc/polkit-action/org.deepin.dde.daemon.system.policy.in

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The PR title/description suggests only a punctuation fix, but the change also alters the phrasing and capitalization of the message; consider aligning the description with the actual scope of the modification.
  • Other messages in similar policy files typically end with a period; consider restoring the trailing period to keep UI text style consistent.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The PR title/description suggests only a punctuation fix, but the change also alters the phrasing and capitalization of the message; consider aligning the description with the actual scope of the modification.
- Other messages in similar policy files typically end with a period; consider restoring the trailing period to keep UI text style consistent.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@mhduiy
Copy link
Copy Markdown
Contributor

mhduiy commented Apr 1, 2026

@leibn123 按照机器人的要求签署一下CLA

@mhduiy
Copy link
Copy Markdown
Contributor

mhduiy commented Apr 1, 2026

另外 Commit msg 不符合规范

1.Fix incorrect punctuation

PMS: BUG-355121
@leibn123
Copy link
Copy Markdown
Contributor Author

leibn123 commented Apr 1, 2026

/retest all

@deepin-ci-robot
Copy link
Copy Markdown

@leibn123: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BLumia
Copy link
Copy Markdown
Member

BLumia commented Apr 1, 2026

recheck

@mhduiy mhduiy merged commit dc32e2a into linuxdeepin:master Apr 9, 2026
17 of 18 checks passed
@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leibn123, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants