test: add unit tests for exec.go file in pkg/utils folder (#755)

* test: add unit tests for exec.go file in pkg/utils folder

Signed-off-by: Prakhar-Shankar <[email protected]>

* fixing gofmt

Signed-off-by: Prakhar-Shankar <[email protected]>

* creating table driven test and also updates TestCheckPodStatus

Signed-off-by: Prakhar-Shankar <[email protected]>

---------

Signed-off-by: Prakhar-Shankar <[email protected]>
Co-authored-by: Shubham Chaudhary <[email protected]>

Author: Prakhar-Shankar

pkg/utils/exec/exec.go

@@ -92,9 +92,20 @@ func checkPodStatus(pod *apiv1.Pod, containerName string) error {
 	if strings.ToLower(string(pod.Status.Phase)) != "running" {
 		return cerrors.Error{ErrorCode: cerrors.ErrorTypeStatusChecks, Reason: fmt.Sprintf("%v pod is not in running state, phase: %v", pod.Name, pod.Status.Phase)}
 	}
+	containerFound := false
 	for _, container := range pod.Status.ContainerStatuses {
-		if container.Name == containerName && !container.Ready {
-			return cerrors.Error{ErrorCode: cerrors.ErrorTypeStatusChecks, Reason: fmt.Sprintf("%v container of %v pod is not in ready state, phase: %v", container.Name, pod.Name, pod.Status.Phase)}
+		if container.Name == containerName {
+			containerFound = true
+			if !container.Ready {
+				return cerrors.Error{ErrorCode: cerrors.ErrorTypeStatusChecks, Reason: fmt.Sprintf("%v container of %v pod is not in ready state, phase: %v", container.Name, pod.Name, pod.Status.Phase)}
+			}
+			break
+		}
+	}
+	if !containerFound {
+		return cerrors.Error{
+			ErrorCode: cerrors.ErrorTypeStatusChecks,
+			Reason:    fmt.Sprintf("container %v not found in pod %v", containerName, pod.Name),
 		}
 	}
 	return nil

pkg/utils/exec/exec_test.go

@@ -0,0 +1,83 @@
+// exec_test.go
+package exec
+
+import (
+	"testing"
+
+	apiv1 "k8s.io/api/core/v1"
+)
+
+func TestSetExecCommandAttributes(t *testing.T) {
+	p := &PodDetails{}
+	SetExecCommandAttributes(p, "test-pod", "test-container", "default")
+
+	if p.PodName != "test-pod" || p.ContainerName != "test-container" || p.Namespace != "default" {
+		t.Errorf("SetExecCommandAttributes failed to set values properly")
+	}
+}
+
+func TestCheckPodStatus(t *testing.T) {
+	tests := []struct {
+		name      string
+		pod       *apiv1.Pod
+		container string
+		wantErr   bool
+	}{
+		{
+			name: "Pod not running",
+			pod: &apiv1.Pod{
+				Status: apiv1.PodStatus{Phase: apiv1.PodPending},
+			},
+			container: "container1",
+			wantErr:   true,
+		},
+		{
+			name: "Container not ready",
+			pod: &apiv1.Pod{
+				Status: apiv1.PodStatus{
+					Phase: apiv1.PodRunning,
+					ContainerStatuses: []apiv1.ContainerStatus{
+						{Name: "container1", Ready: false},
+					},
+				},
+			},
+			container: "container1",
+			wantErr:   true,
+		},
+		{
+			name: "Healthy pod and container",
+			pod: &apiv1.Pod{
+				Status: apiv1.PodStatus{
+					Phase: apiv1.PodRunning,
+					ContainerStatuses: []apiv1.ContainerStatus{
+						{Name: "container1", Ready: true},
+					},
+				},
+			},
+			container: "container1",
+			wantErr:   false,
+		},
+		{
+			name: "Container name not matching",
+			pod: &apiv1.Pod{
+				Status: apiv1.PodStatus{
+					Phase: apiv1.PodRunning,
+					ContainerStatuses: []apiv1.ContainerStatus{
+						{Name: "other-container", Ready: true},
+					},
+				},
+			},
+			container: "container1",
+			wantErr:   true,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			err := checkPodStatus(tt.pod, tt.container)
+			if (err != nil) != tt.wantErr {
+				t.Errorf("checkPodStatus() error = %v, wantErr %v", err, tt.wantErr)
+			}
+		})
+	}
+}