vars: Replace separate configuration vars with mailcow_config dict #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felinira
force-pushed
the
wip/config-variables
branch
from
5402938 to
8ecc25d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the separate configuration variables with one
mailcow__configvariable. This allows to add arbitrary custom variables to mailcow.conf.For backwards compatibility we fill in the default values with the old variables. This should allow running the updated role without changing anything in the configuration.
When you specify a non-empty
mailcow__configfor the first time, any values that are not configured in ansible will be commented out from the file. This ensures idempotency in the configuration of the role, while not being too disruptive when someone forgets to specify a config.Closes #39 #51 #52