Merge pull request #67 from marshallswain/fix/individual-requests-ignore-keyHere-keyThere

fratzinger · web-flow · commit dd1396f6bbe1 · 2025-11-20T14:43:37.000+01:00
fix: rm assert keyHere/keyThere for individual includes
diff --git a/src/utils/shallow-populate.utils.ts b/src/utils/shallow-populate.utils.ts
@@ -79,15 +79,6 @@ export const assertIncludes = (includes: PopulateObject[]): void => {
         'shallowPopulate hook: Every `include` with attribute `keyHere` or `keyThere` also needs the other attribute defined',
       )
     }
-
-    if (
-      include.requestPerItem &&
-      ('keyHere' in include || 'keyThere' in include)
-    ) {
-      throw new Error(
-        'shallowPopulate hook: The attributes `keyHere` and `keyThere` are useless when you set `requestPerItem: true`. You should remove these properties',
-      )
-    }
   }
 
   const uniqueNameAs = _uniqBy(includes, 'nameAs')

Original file line number	Diff line number	Diff line change
`@@ -79,15 +79,6 @@ export const assertIncludes = (includes: PopulateObject[]): void => {`
`79`	`79`	'shallowPopulate hook: Every `include` with attribute `keyHere` or `keyThere` also needs the other attribute defined',
`80`	`80`	`)`
`81`	`81`	`}`
`82`		`-`
`83`		`- if (`
`84`		`- include.requestPerItem &&`
`85`		`- ('keyHere' in include \|\| 'keyThere' in include)`
`86`		`- ) {`
`87`		`- throw new Error(`
`88`		- 'shallowPopulate hook: The attributes `keyHere` and `keyThere` are useless when you set `requestPerItem: true`. You should remove these properties',
`89`		`- )`
`90`		`- }`
`91`	`82`	`}`
`92`	`83`
`93`	`84`	`const uniqueNameAs = _uniqBy(includes, 'nameAs')`