Skip to content

Fix and enhancement for VCP date tests #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JKingweb wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix and enhancement for VCP date tests #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
063b37b
VCP requires that dates be normalized with zones without colons
JKingweb Jan 19, 2026
f126714
Mark the test for parser issue 66 as tentative
JKingweb Jan 28, 2026
315958a
Cover more cases in VCP dt- property processing
JKingweb Jan 30, 2026
42ea82a
Add tests for VCP implied date
JKingweb Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...t/nested/nested-microformat-mistyped.html → ...entative-nested-microformat-mistyped.html
View file
Open in desktop
File renamed without changes.
0 ...t/nested/nested-microformat-mistyped.json → ...entative-nested-microformat-mistyped.json
View file
Open in desktop
File renamed without changes.
71 changes: 53 additions & 18 deletions tests/microformats-v2-unit/value/value-dt.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,11 @@
<div class="h-test-acceptable">
<div class="p-name">NotPartOfTest</div>
<div class="dt-not-a-date">Valid <span class="value">NotADate</span> Valid</div>
<div class="dt-1-with-tz">Invalid <span class="value">2000-01-01 00:00:00+00:00</span> Invalid</div>
<div class="dt-2-with-tz">Invalid <span class="value">2000-01-01</span><span class="value">00:00:00+00:00</span> Invalid</div>
<div class="dt-1-with-tz">Invalid <span class="value">2000-01-01 00:00:00+0000</span> Invalid</div>
<div class="dt-2-with-tz">Invalid <span class="value">2000-01-01</span><span class="value">00:00:00+0000</span> Invalid</div>
<div class="dt-3-with-tz">Invalid <span class="value">2000-01-01 00:00:00</span><span class="value">+0000</span> Invalid</div>
<div class="dt-4-with-tz">Invalid <span class="value">2000-01-01</span><span class="value">00:00:00</span><span class="value">+0000</span> Invalid</div>
<div class="dt-misordered">Invalid <span class="value">+0000</span><span class="value">00:00:00</span><span class="value">2000-01-01</span> Invalid</div>
<div class="dt-1-first-wins">
Invalid
<span class="value">2000-01-01</span>
Expand All @@ -57,9 +60,41 @@
Invalid
<span class="value">2000-01-01</span>
<span class="value">00:00:00</span>
<span class="value">00:00:00+00:00</span>
<span class="value">00:00:00+0000</span>
Invalid
</div>
<div class="dt-4-first-wins">
Invalid
<span class="value">2000-01-01</span>
<span class="value">+0000</span>
<span class="value">23:59:59+0000</span>
<span class="value">00:00:00</span>
Invalid
</div>
<div class="dt-5-first-wins">
Invalid
<span class="value">2000-01-01</span>
<span class="value">+0000</span>
<span class="value">23:59:59+0000</span>
Invalid
</div>
</div>

<div class="h-test-implied-date-missing">
<div class="p-name">NotPartOfTest</div>
<div class="dt-time-only">Valid <span class="value">00:00:00+0000</span> Valid</div>
</div>

<div class="h-test-implied-date-before">
<div class="p-name">NotPartOfTest</div>
<div class="dt-implied">Invalid <span class="value">2000-01-01 23:59:59+0000</span> Invalid</div>
<div class="dt-time-only">Invalid <span class="value">00:00:00+0000</span> Invalid</div>
</div>

<div class="h-test-implied-date-after">
<div class="p-name">NotPartOfTest</div>
<div class="dt-time-only">Invalid <span class="value">00:00:00+0000</span> Invalid</div>
<div class="dt-implied">Invalid <span class="value">2000-01-01 23:59:59+0000</span> Invalid</div>
</div>

<div class="h-test-img">
Expand All @@ -78,46 +113,46 @@

<div class="h-test-data">
<div class="p-name">NotPartOfTest</div>
<div class="dt-filled">Invalid <data class="value" value="2000-01-01">Invalid</data> Invalid</div>
<div class="dt-empty">Va<data class="value" value="">l</data>id</div>
<div class="dt-filled">Invalid <data class="value" value="2000-01-01">2099-01-01</data> Invalid</div>
<div class="dt-empty">Valid <data class="value" value="">2099-01-01</data> Valid</div>
<div class="dt-missing">Invalid <data class="value">2000-01-01</data> Invalid</div>
</div>

<div class="h-test-abbr">
<div class="p-name">NotPartOfTest</div>
<div class="dt-filled">Invalid <abbr class="value" title="2000-01-01">Invalid</abbr> Invalid</div>
<div class="dt-empty">Va<abbr class="value" title="">l</abbr>id</div>
<div class="dt-filled">Invalid <abbr class="value" title="2000-01-01">2099-01-01</abbr> Invalid</div>
<div class="dt-empty">Valid <abbr class="value" title="">2099-01-01</abbr> Valid</div>
<div class="dt-missing">Invalid <abbr class="value">2000-01-01</abbr> Invalid</div>
</div>

<!-- The datetime attribute on these elements only applies to date parsing, and not other VCP parsing -->
<div class="h-test-time">
<div class="p-name">NotPartOfTest</div>
<div class="dt-filled">Invalid <time class="value" datetime="2000-01-01">Invalid</time> Invalid</div>
<div class="dt-empty">Va<time class="value" datetime="">l</time>id</div>
<div class="dt-filled">Invalid <time class="value" datetime="2000-01-01">2099-01-01</time> Invalid</div>
<div class="dt-empty">Valid <time class="value" datetime="">2099-01-01</time> Valid</div>
<div class="dt-missing">Invalid <time class="value">2000-01-01</time> Invalid</div>
</div>

<div class="h-test-ins">
<div class="p-name">NotPartOfTest</div>
<div class="dt-filled">Invalid <ins class="value" datetime="2000-01-01">Invalid</ins> Invalid</div>
<div class="dt-empty">Va<ins class="value" datetime="">l</ins>id</div>
<div class="dt-filled">Invalid <ins class="value" datetime="2000-01-01">2099-01-01</ins> Invalid</div>
<div class="dt-empty">Valid <ins class="value" datetime="">2099-01-01</ins> Valid</div>
<div class="dt-missing">Invalid <ins class="value">2000-01-01</ins> Invalid</div>
</div>

<div class="h-test-del">
<div class="p-name">NotPartOfTest</div>
<div class="dt-filled">Invalid <del class="value" datetime="2000-01-01">Invalid</del> Invalid</div>
<div class="dt-empty">Va<del class="value" datetime="">l</del>id</div>
<div class="dt-filled">Invalid <del class="value" datetime="2000-01-01">2099-01-01</del> Invalid</div>
<div class="dt-empty">Valid <del class="value" datetime="">2099-01-01</del> Valid</div>
<div class="dt-missing">Invalid <del class="value">2000-01-01</del> Invalid</div>
</div>

<!-- This test checks Value Class Pattern execution order within dt-property processing -->
<div class="h-test-override">
<div class="p-name">NotPartOfTest</div>
<time class="dt-time" datetime="Invalid">Invalid <span class="value">2000-01-01</span> Invalid</time>
<ins class="dt-ins" datetime="Invalid">Invalid <span class="value">2000-01-01</span> Invalid</ins>
<del class="dt-del" datetime="Invalid">Invalid <span class="value">2000-01-01</span> Invalid</del>
<abbr class="dt-abbr" title="Invalid">Invalid <span class="value">2000-01-01</span> Invalid</abbr>
<data class="dt-data" value="Invalid">Invalid <span class="value">2000-01-01</span> Invalid</data>
<time class="dt-time" datetime="2099-01-01">Invalid <span class="value">2000-01-01</span> Invalid</time>
<ins class="dt-ins" datetime="2099-01-01">Invalid <span class="value">2000-01-01</span> Invalid</ins>
<del class="dt-del" datetime="2099-01-01">Invalid <span class="value">2000-01-01</span> Invalid</del>
<abbr class="dt-abbr" title="2099-01-01">Invalid <span class="value">2000-01-01</span> Invalid</abbr>
<data class="dt-data" value="2099-01-01">Invalid <span class="value">2000-01-01</span> Invalid</data>
</div>
74 changes: 67 additions & 7 deletions tests/microformats-v2-unit/value/value-dt.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,19 @@
"Valid NotADate Valid"
],
"1-with-tz": [
"2000-01-01 00:00:00+00:00"
"2000-01-01 00:00:00+0000"
],
"2-with-tz": [
"2000-01-01 00:00:00+00:00"
"2000-01-01 00:00:00+0000"
],
"3-with-tz": [
"2000-01-01 00:00:00+0000"
],
"4-with-tz": [
"2000-01-01 00:00:00+0000"
],
"misordered": [
"2000-01-01 00:00:00+0000"
],
"1-first-wins": [
"2000-01-01"
Expand All @@ -85,6 +94,57 @@
],
"3-first-wins": [
"2000-01-01 00:00:00"
],
"4-first-wins": [
"2000-01-01 00:00:00+0000"
],
"5-first-wins": [
"2000-01-01"
]
}
},
{
"type": [
"h-test-implied-date-missing"
],
"properties": {
"name": [
"NotPartOfTest"
],
"time-only": [
"Valid 00:00:00+0000 Valid"
]
}
},
{
"type": [
"h-test-implied-date-before"
],
"properties": {
"name": [
"NotPartOfTest"
],
"implied": [
"2000-01-01 23:59:59+0000"
],
"time-only": [
"2000-01-01 00:00:00+0000"
]
}
},
{
"type": [
"h-test-implied-date-after"
],
"properties": {
"name": [
"NotPartOfTest"
],
"time-only": [
"2000-01-01 00:00:00+0000"
],
"implied": [
"2000-01-01 23:59:59+0000"
]
}
},
Expand Down Expand Up @@ -138,7 +198,7 @@
"2000-01-01"
],
"empty": [
"Valid"
"Valid 2099-01-01 Valid"
],
"missing": [
"2000-01-01"
Expand All @@ -157,7 +217,7 @@
"2000-01-01"
],
"empty": [
"Valid"
"Valid 2099-01-01 Valid"
],
"missing": [
"2000-01-01"
Expand All @@ -176,7 +236,7 @@
"2000-01-01"
],
"empty": [
"Valid"
"Valid 2099-01-01 Valid"
],
"missing": [
"2000-01-01"
Expand All @@ -195,7 +255,7 @@
"2000-01-01"
],
"empty": [
"Valid"
"Valid 2099-01-01 Valid"
],
"missing": [
"2000-01-01"
Expand All @@ -214,7 +274,7 @@
"2000-01-01"
],
"empty": [
"Valid"
"Valid 2099-01-01 Valid"
],
"missing": [
"2000-01-01"
Expand Down