-
Notifications
You must be signed in to change notification settings - Fork 111
AdvLoggerPkg: Fix memory bucket stability #799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/202502
Are you sure you want to change the base?
AdvLoggerPkg: Fix memory bucket stability #799
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/202502 #799 +/- ##
================================================
Coverage ? 5.08%
================================================
Files ? 35
Lines ? 3892
Branches ? 247
================================================
Hits ? 198
Misses ? 3692
Partials ? 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
My understanding is that there are at least two additional changes likely needed.
For others that have worked more with adv logger, is that true? Also, any quick sanity checks of the current changes (while those updates are being made) is appreciated. |
os-d
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As noted offline, I think this works, but we should only do this if we aren't doing the fixed buffer region
Right now, the PEI Core instance of AdvancedLoggerLib will always allocate the logger buffer as `EfiRuntimeServicesData`. This means it is not allocated into the DXE Core managed RT Services Data memory bucket. The DXE Core instance of AdvancedLoggerLib either continues to use this buffer it is provided or allocates a new `EfiReservedMemoryType` buffer. This change always allocates a `EfiReservedMemoryType` buffer in the DXE Core instance to ensure it is allocated from the reserved memory type buckets setup by the DXE Core. The PEI Core logger buffer is updated to be `EfiBootServicesData` so it does not affect runtime allocations. Signed-off-by: Michael Kubacki <[email protected]>
Update the library to use the standard C predefined identifier `__func__` instead of `__FUNCTION__` to improve code portability. This was started in some recently modified lines in the library. The remaining instances have been updated for consistency in this change. Signed-off-by: Michael Kubacki <[email protected]>
85a781d to
af44b6e
Compare
Description
Note: PR is in draft while WIP
Right now, the PEI Core instance of AdvancedLoggerLib will always allocate the logger buffer as
EfiRuntimeServicesData. This means it is not allocated into the DXE Core managed RT Services Data memory bucket. The DXE Core instance of AdvancedLoggerLib either continues to use this buffer it is provided or allocates a newEfiReservedMemoryTypebuffer.This change always allocates a
EfiReservedMemoryTypebuffer in the DXE Core instance to ensure it is allocated from the reserved memory type buckets setup by the DXE Core. The PEI Core logger buffer is updated to beEfiBootServicesDataso it does not affect runtime allocations.How This Was Tested
Integration Instructions