Skip to content

Commit 25d94f6

Browse files
authored
Fix JSX name in folding ranges (#2199)
1 parent 7c2dab6 commit 25d94f6

File tree

2 files changed

+27
-1
lines changed

2 files changed

+27
-1
lines changed
Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
package fourslash_test
2+
3+
import (
4+
"testing"
5+
6+
"github.com/microsoft/typescript-go/internal/fourslash"
7+
"github.com/microsoft/typescript-go/internal/testutil"
8+
)
9+
10+
func TestFoldingRangeJSXPropertyAccess(t *testing.T) {
11+
t.Parallel()
12+
13+
defer testutil.RecoverAndFail(t, "Panic on fourslash test")
14+
const content = `// @jsx: preserve
15+
// @Filename: /a.tsx
16+
const Components =[| {
17+
Nested: () => null
18+
}|];
19+
20+
export const Test = () =>[| {
21+
return [|<Components.Nested></Components.Nested>|];
22+
}|];`
23+
f, done := fourslash.NewFourslash(t, nil /*capabilities*/, content)
24+
defer done()
25+
f.VerifyOutliningSpans(t)
26+
}

internal/ls/folding.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -430,7 +430,7 @@ func spanForJSXElement(node *ast.Node, sourceFile *ast.SourceFile, l *LanguageSe
430430
if node.Kind == ast.KindJsxElement {
431431
jsxElement := node.AsJsxElement()
432432
textRange := l.createLspRangeFromBounds(astnav.GetStartOfNode(jsxElement.OpeningElement, sourceFile, false /*includeJSDoc*/), jsxElement.ClosingElement.End(), sourceFile)
433-
tagName := jsxElement.OpeningElement.TagName().Text()
433+
tagName := scanner.GetTextOfNode(jsxElement.OpeningElement.TagName())
434434
bannerText := "<" + tagName + ">...</" + tagName + ">"
435435
return createFoldingRange(textRange, "", bannerText)
436436
}

0 commit comments

Comments
 (0)