Fourslash: open all test files (#1422)

gabritto · web-flow · commit 53e5c705dfb4 · 2025-07-22T17:00:13.000Z
diff --git a/internal/fourslash/_scripts/failingTests.txt b/internal/fourslash/_scripts/failingTests.txt
@@ -189,6 +189,8 @@ TestFindAllRefsModuleDotExports
 TestFindAllRefsReExport_broken
 TestFindAllRefs_importType_typeofImport
 TestFindReferencesAfterEdit
+TestFindReferencesBindingPatternInJsdocNoCrash1
+TestFindReferencesBindingPatternInJsdocNoCrash2
 TestGenericTypeWithMultipleBases1MultiFile
 TestGetJavaScriptCompletions10
 TestGetJavaScriptCompletions12
@@ -223,10 +225,6 @@ TestImportStatementCompletions4
 TestImportStatementCompletions_noPatternAmbient
 TestImportStatementCompletions_pnpmTransitive
 TestImportTypeMemberCompletions
-TestJavaScriptModules12
-TestJavaScriptModules13
-TestJavaScriptModules14
-TestJavaScriptModules19
 TestJavascriptModules20
 TestJavascriptModules21
 TestJavascriptModulesTypeImport
diff --git a/internal/fourslash/fourslash.go b/internal/fourslash/fourslash.go
@@ -149,9 +149,10 @@ func NewFourslash(t *testing.T, capabilities *lsproto.ClientCapabilities, conten
 		scriptInfos[filePath] = newScriptInfo(filePath, file.Content)
 	}
 
-	compilerOptions := &core.CompilerOptions{}
+	compilerOptions := &core.CompilerOptions{
+		SkipDefaultLibCheck: core.TSTrue,
+	}
 	harnessutil.SetCompilerOptionsFromTestConfig(t, testData.GlobalOptions, compilerOptions)
-	compilerOptions.SkipDefaultLibCheck = core.TSTrue
 
 	inputReader, inputWriter := newLSPPipe()
 	outputReader, outputWriter := newLSPPipe()
@@ -202,7 +203,10 @@ func NewFourslash(t *testing.T, capabilities *lsproto.ClientCapabilities, conten
 	// !!! replace with a proper request *after initialize*
 	f.server.SetCompilerOptionsForInferredProjects(compilerOptions)
 	f.initialize(t, capabilities)
-	f.openFile(t, f.testData.Files[0].fileName)
+	for _, file := range testData.Files {
+		f.openFile(t, file.fileName)
+	}
+	f.activeFilename = f.testData.Files[0].fileName
 
 	t.Cleanup(func() {
 		inputWriter.Close()
diff --git a/internal/fourslash/tests/gen/findReferencesBindingPatternInJsdocNoCrash1_test.go b/internal/fourslash/tests/gen/findReferencesBindingPatternInJsdocNoCrash1_test.go
@@ -9,7 +9,7 @@ import (
 
 func TestFindReferencesBindingPatternInJsdocNoCrash1(t *testing.T) {
 	t.Parallel()
-
+	t.Skip()
 	defer testutil.RecoverAndFail(t, "Panic on fourslash test")
 	const content = `// @moduleResolution: node
 // @Filename: node_modules/use-query/package.json
diff --git a/internal/fourslash/tests/gen/findReferencesBindingPatternInJsdocNoCrash2_test.go b/internal/fourslash/tests/gen/findReferencesBindingPatternInJsdocNoCrash2_test.go
@@ -9,7 +9,7 @@ import (
 
 func TestFindReferencesBindingPatternInJsdocNoCrash2(t *testing.T) {
 	t.Parallel()
-
+	t.Skip()
 	defer testutil.RecoverAndFail(t, "Panic on fourslash test")
 	const content = `// @moduleResolution: node
 // @Filename: node_modules/use-query/package.json
diff --git a/internal/fourslash/tests/gen/javaScriptModules12_test.go b/internal/fourslash/tests/gen/javaScriptModules12_test.go
@@ -11,7 +11,7 @@ import (
 
 func TestJavaScriptModules12(t *testing.T) {
 	t.Parallel()
-	t.Skip()
+
 	defer testutil.RecoverAndFail(t, "Panic on fourslash test")
 	const content = `// @allowJs: true
 // @Filename: mod1.js
diff --git a/internal/fourslash/tests/gen/javaScriptModules13_test.go b/internal/fourslash/tests/gen/javaScriptModules13_test.go
@@ -11,7 +11,7 @@ import (
 
 func TestJavaScriptModules13(t *testing.T) {
 	t.Parallel()
-	t.Skip()
+
 	defer testutil.RecoverAndFail(t, "Panic on fourslash test")
 	const content = `// @allowJs: true
 // @Filename: myMod.js
diff --git a/internal/fourslash/tests/gen/javaScriptModules14_test.go b/internal/fourslash/tests/gen/javaScriptModules14_test.go
@@ -11,7 +11,7 @@ import (
 
 func TestJavaScriptModules14(t *testing.T) {
 	t.Parallel()
-	t.Skip()
+
 	defer testutil.RecoverAndFail(t, "Panic on fourslash test")
 	const content = `// @allowJs: true
 // @Filename: myMod.js
diff --git a/internal/fourslash/tests/gen/javaScriptModules19_test.go b/internal/fourslash/tests/gen/javaScriptModules19_test.go
@@ -11,7 +11,7 @@ import (
 
 func TestJavaScriptModules19(t *testing.T) {
 	t.Parallel()
-	t.Skip()
+
 	defer testutil.RecoverAndFail(t, "Panic on fourslash test")
 	const content = `// @allowJs: true
 // @Filename: myMod.js
diff --git a/testdata/baselines/reference/fourslash/findAllRef/EsModuleInteropFindAllReferences2.baseline.jsonc b/testdata/baselines/reference/fourslash/findAllRef/EsModuleInteropFindAllReferences2.baseline.jsonc
@@ -10,6 +10,12 @@
 // export const /*FIND ALL REFS*/[|x|]: number;
 
 
+// === /b.ts ===
+
+// import a from "./a";
+// a.[|x|];
+
+
 
 
 // === findAllReferences ===
diff --git a/testdata/baselines/reference/fourslash/findAllRef/FindAllReferencesUndefined.baseline.jsonc b/testdata/baselines/reference/fourslash/findAllRef/FindAllReferencesUndefined.baseline.jsonc
@@ -4,3 +4,8 @@
 // /*FIND ALL REFS*/[|undefined|];
 // 
 // void [|undefined|];
+
+
+// === /b.ts ===
+
+// [|undefined|];
diff --git a/testdata/baselines/reference/fourslash/findAllRef/FindAllRefsForUMDModuleAlias1.baseline.jsonc b/testdata/baselines/reference/fourslash/findAllRef/FindAllRefsForUMDModuleAlias1.baseline.jsonc
@@ -11,6 +11,12 @@
 // export as namespace /*FIND ALL REFS*/[|myLib|];
 
 
+// === /1.ts ===
+
+// /// <reference path="0.d.ts" />
+// [|myLib|].doThing();
+
+
 
 
 // === findAllReferences ===
diff --git a/testdata/baselines/reference/fourslash/findAllRef/FindAllRefsJsThisPropertyAssignment2.baseline.jsonc b/testdata/baselines/reference/fourslash/findAllRef/FindAllRefsJsThisPropertyAssignment2.baseline.jsonc
@@ -12,6 +12,19 @@
 // });
 
 
+// === /b.ts ===
+
+// import { infer } from "./infer";
+// infer({
+//     m: {
+//         initData() {
+//             this.[|x|] = 1;
+//             this.[|x|];
+//         },
+//     }
+// });
+
+
 // === /infer.d.ts ===
 
 // export declare function infer(o: { m: Record<string, Function> } & ThisType<{ [|x|]: number }>): void;
diff --git a/testdata/baselines/reference/fourslash/findAllRef/FindAllRefsOnDecorators.baseline.jsonc b/testdata/baselines/reference/fourslash/findAllRef/FindAllRefsOnDecorators.baseline.jsonc
@@ -12,6 +12,15 @@
 // [|decorator|]();
 
 
+// === /b.ts ===
+
+// @[|decorator|] @[|decorator|]("again")
+// class C {
+//     @[|decorator|]
+//     method() {}
+// }
+
+
 
 
 // === findAllReferences ===
@@ -23,6 +32,15 @@
 // /*FIND ALL REFS*/[|decorator|]();
 
 
+// === /b.ts ===
+
+// @[|decorator|] @[|decorator|]("again")
+// class C {
+//     @[|decorator|]
+//     method() {}
+// }
+
+
 
 
 // === findAllReferences ===
diff --git a/testdata/baselines/reference/fourslash/findAllRef/FindAllRefsOnDefinition.baseline.jsonc b/testdata/baselines/reference/fourslash/findAllRef/FindAllRefsOnDefinition.baseline.jsonc
@@ -17,6 +17,15 @@
 // // --- (line: 11) skipped ---
 
 
+// === /findAllRefsOnDefinition.ts ===
+
+// import Second = require("./findAllRefsOnDefinition-import");
+// 
+// var second = new Second.Test()
+// second.[|start|]();
+// second.stop();
+
+
 
 
 // === findAllReferences ===
diff --git a/testdata/baselines/reference/fourslash/findAllRef/FindAllRefsOnDefinition2.baseline.jsonc b/testdata/baselines/reference/fourslash/findAllRef/FindAllRefsOnDefinition2.baseline.jsonc
@@ -14,6 +14,14 @@
 // }
 
 
+// === /findAllRefsOnDefinition2.ts ===
+
+// import Second = require("./findAllRefsOnDefinition2-import");
+// 
+// var start: Second.Test.[|start|];
+// var stop: Second.Test.stop;
+
+
 
 
 // === findAllReferences ===
diff --git a/testdata/baselines/reference/fourslash/findAllRef/FindReferencesAcrossMultipleProjects.baseline.jsonc b/testdata/baselines/reference/fourslash/findAllRef/FindReferencesAcrossMultipleProjects.baseline.jsonc
@@ -9,6 +9,18 @@
 // var /*FIND ALL REFS*/[|x|]: number;
 
 
+// === /b.ts ===
+
+// /// <reference path="a.ts" />
+// [|x|]++;
+
+
+// === /c.ts ===
+
+// /// <reference path="a.ts" />
+// [|x|]++;
+
+
 
 
 // === findAllReferences ===
@@ -23,6 +35,12 @@
 // /*FIND ALL REFS*/[|x|]++;
 
 
+// === /c.ts ===
+
+// /// <reference path="a.ts" />
+// [|x|]++;
+
+
 
 
 // === findAllReferences ===
diff --git a/testdata/baselines/reference/fourslash/findAllRef/FindReferencesBindingPatternInJsdocNoCrash1.baseline.jsonc b/testdata/baselines/reference/fourslash/findAllRef/FindReferencesBindingPatternInJsdocNoCrash1.baseline.jsonc
diff --git a/testdata/baselines/reference/fourslash/findAllRef/FindReferencesBindingPatternInJsdocNoCrash2.baseline.jsonc b/testdata/baselines/reference/fourslash/findAllRef/FindReferencesBindingPatternInJsdocNoCrash2.baseline.jsonc
diff --git a/testdata/baselines/reference/fourslash/findAllRef/ReferenceToClass.baseline.jsonc b/testdata/baselines/reference/fourslash/findAllRef/ReferenceToClass.baseline.jsonc
@@ -16,6 +16,11 @@
 // }
 
 
+// === /referenceToClass_2.ts ===
+
+// var k: [|foo|];
+
+
 
 
 // === findAllReferences ===
@@ -36,6 +41,11 @@
 // }
 
 
+// === /referenceToClass_2.ts ===
+
+// var k: [|foo|];
+
+
 
 
 // === findAllReferences ===
@@ -56,6 +66,11 @@
 // }
 
 
+// === /referenceToClass_2.ts ===
+
+// var k: [|foo|];
+
+
 
 
 // === findAllReferences ===
@@ -76,6 +91,11 @@
 // }
 
 
+// === /referenceToClass_2.ts ===
+
+// var k: [|foo|];
+
+
 
 
 // === findAllReferences ===
@@ -96,6 +116,11 @@
 // }
 
 
+// === /referenceToClass_2.ts ===
+
+// var k: [|foo|];
+
+
 
 
 // === findAllReferences ===
diff --git a/testdata/baselines/reference/fourslash/findAllRef/ReferencesBloomFilters.baseline.jsonc b/testdata/baselines/reference/fourslash/findAllRef/ReferencesBloomFilters.baseline.jsonc
@@ -2,3 +2,13 @@
 // === /declaration.ts ===
 
 // var container = { /*FIND ALL REFS*/[|searchProp|] : 1 };
+
+
+// === /expression.ts ===
+
+// function blah() { return (1 + 2 + container.[|searchProp|]()) === 2;  };
+
+
+// === /stringIndexer.ts ===
+
+// function blah2() { container["[|searchProp|]"] };
diff --git a/testdata/baselines/reference/fourslash/findAllRef/ReferencesBloomFilters2.baseline.jsonc b/testdata/baselines/reference/fourslash/findAllRef/ReferencesBloomFilters2.baseline.jsonc
@@ -2,3 +2,13 @@
 // === /declaration.ts ===
 
 // var container = { /*FIND ALL REFS*/[|42|]: 1 };
+
+
+// === /expression.ts ===
+
+// function blah() { return (container[[|42|]]) === 2;  };
+
+
+// === /stringIndexer.ts ===
+
+// function blah2() { container["[|42|]"] };
diff --git a/testdata/baselines/reference/fourslash/findAllRef/ReferencesBloomFilters3.baseline.jsonc b/testdata/baselines/reference/fourslash/findAllRef/ReferencesBloomFilters3.baseline.jsonc
@@ -4,6 +4,11 @@
 // enum Test { /*FIND ALL REFS*/"[|42|]" = 1 };
 
 
+// === /expression.ts ===
+
+// (Test[[|42|]]);
+
+
 
 
 // === findAllReferences ===
@@ -12,6 +17,11 @@
 // enum Test { "/*FIND ALL REFS*/[|42|]" = 1 };
 
 
+// === /expression.ts ===
+
+// (Test[[|42|]]);
+
+
 
 
 // === findAllReferences ===
diff --git a/testdata/baselines/reference/fourslash/findAllRef/ReferencesForExternalModuleNames.baseline.jsonc b/testdata/baselines/reference/fourslash/findAllRef/ReferencesForExternalModuleNames.baseline.jsonc
@@ -11,6 +11,11 @@
 // }
 
 
+// === /referencesForGlobals_2.ts ===
+
+// import f = require("[|foo|]");
+
+
 
 
 // === findAllReferences ===
diff --git a/testdata/baselines/reference/fourslash/findAllRef/ReferencesForGlobals.baseline.jsonc b/testdata/baselines/reference/fourslash/findAllRef/ReferencesForGlobals.baseline.jsonc
diff --git a/testdata/baselines/reference/fourslash/findAllRef/ReferencesForGlobals2.baseline.jsonc b/testdata/baselines/reference/fourslash/findAllRef/ReferencesForGlobals2.baseline.jsonc
diff --git a/testdata/baselines/reference/fourslash/findAllRef/ReferencesForGlobals3.baseline.jsonc b/testdata/baselines/reference/fourslash/findAllRef/ReferencesForGlobals3.baseline.jsonc
diff --git a/testdata/baselines/reference/fourslash/findAllRef/ReferencesForGlobals4.baseline.jsonc b/testdata/baselines/reference/fourslash/findAllRef/ReferencesForGlobals4.baseline.jsonc
diff --git a/testdata/baselines/reference/fourslash/findAllRef/ReferencesForGlobals5.baseline.jsonc b/testdata/baselines/reference/fourslash/findAllRef/ReferencesForGlobals5.baseline.jsonc
diff --git a/testdata/baselines/reference/fourslash/findAllRef/ReferencesForStatic.baseline.jsonc b/testdata/baselines/reference/fourslash/findAllRef/ReferencesForStatic.baseline.jsonc
diff --git a/testdata/baselines/reference/fourslash/findAllRef/RemoteGetReferences.baseline.jsonc b/testdata/baselines/reference/fourslash/findAllRef/RemoteGetReferences.baseline.jsonc
