Incremental port (#1322)

Author: sheetalkamat

cmd/tsgo/main.go

@@ -20,5 +20,6 @@ func runMain() int {
 			return runAPI(args[1:])
 		}
 	}
-	return int(execute.CommandLine(newSystem(), nil, args))
+	result := execute.CommandLine(newSystem(), args, false)
+	return int(result.Status)
 }

internal/ast/diagnostic.go

@@ -21,6 +21,7 @@ type Diagnostic struct {
 	relatedInformation []*Diagnostic
 	reportsUnnecessary bool
 	reportsDeprecated  bool
+	skippedOnNoEmit    bool
 }
 
 func (d *Diagnostic) File() *SourceFile                 { return d.file }
@@ -35,10 +36,12 @@ func (d *Diagnostic) MessageChain() []*Diagnostic       { return d.messageChain
 func (d *Diagnostic) RelatedInformation() []*Diagnostic { return d.relatedInformation }
 func (d *Diagnostic) ReportsUnnecessary() bool          { return d.reportsUnnecessary }
 func (d *Diagnostic) ReportsDeprecated() bool           { return d.reportsDeprecated }
+func (d *Diagnostic) SkippedOnNoEmit() bool             { return d.skippedOnNoEmit }
 
 func (d *Diagnostic) SetFile(file *SourceFile)                  { d.file = file }
 func (d *Diagnostic) SetLocation(loc core.TextRange)            { d.loc = loc }
 func (d *Diagnostic) SetCategory(category diagnostics.Category) { d.category = category }
+func (d *Diagnostic) SetSkippedOnNoEmit()                       { d.skippedOnNoEmit = true }
 
 func (d *Diagnostic) SetMessageChain(messageChain []*Diagnostic) *Diagnostic {
 	d.messageChain = messageChain
@@ -69,6 +72,32 @@ func (d *Diagnostic) Clone() *Diagnostic {
 	return &result
 }
 
+func NewDiagnosticWith(
+	file *SourceFile,
+	loc core.TextRange,
+	code int32,
+	category diagnostics.Category,
+	message string,
+	messageChain []*Diagnostic,
+	relatedInformation []*Diagnostic,
+	reportsUnnecessary bool,
+	reportsDeprecated bool,
+	skippedOnNoEmit bool,
+) *Diagnostic {
+	return &Diagnostic{
+		file:               file,
+		loc:                loc,
+		code:               code,
+		category:           category,
+		message:            message,
+		messageChain:       messageChain,
+		relatedInformation: relatedInformation,
+		reportsUnnecessary: reportsUnnecessary,
+		reportsDeprecated:  reportsDeprecated,
+		skippedOnNoEmit:    skippedOnNoEmit,
+	}
+}
+
 func NewDiagnostic(file *SourceFile, loc core.TextRange, message *diagnostics.Message, args ...any) *Diagnostic {
 	return &Diagnostic{
 		file:               file,

internal/ast/utilities.go

@@ -1635,6 +1635,10 @@ func IsModuleAugmentationExternal(node *Node) bool {
 	return false
 }
 
+func IsModuleWithStringLiteralName(node *Node) bool {
+	return IsModuleDeclaration(node) && node.Name().Kind == KindStringLiteral
+}
+
 func GetContainingClass(node *Node) *Node {
 	return FindAncestor(node.Parent, IsClassLike)
 }

internal/checker/checker.go

@@ -853,6 +853,8 @@ type Checker struct {
 	packagesMap                                 map[string]bool
 	activeMappers                               []*TypeMapper
 	activeTypeMappersCaches                     []map[string]*Type
+	ambientModulesOnce                          sync.Once
+	ambientModules                              []*ast.Symbol
 }
 
 func NewChecker(program Program) *Checker {
@@ -2085,7 +2087,7 @@ func (c *Checker) getSymbol(symbols ast.SymbolTable, name string, meaning ast.Sy
 }
 
 func (c *Checker) CheckSourceFile(ctx context.Context, sourceFile *ast.SourceFile) {
-	if SkipTypeChecking(sourceFile, c.compilerOptions, c.program) {
+	if SkipTypeChecking(sourceFile, c.compilerOptions, c.program, false) {
 		return
 	}
 	c.checkSourceFile(ctx, sourceFile)
@@ -10069,7 +10071,7 @@ func (c *Checker) checkCollisionWithRequireExportsInGeneratedCode(node *ast.Node
 	parent := ast.GetDeclarationContainer(node)
 	if ast.IsSourceFile(parent) && ast.IsExternalOrCommonJSModule(parent.AsSourceFile()) {
 		// If the declaration happens to be in external module, report error that require and exports are reserved keywords
-		c.error(name, diagnostics.Duplicate_identifier_0_Compiler_reserves_name_1_in_top_level_scope_of_a_module, scanner.DeclarationNameToString(name), scanner.DeclarationNameToString(name))
+		c.errorSkippedOnNoEmit(name, diagnostics.Duplicate_identifier_0_Compiler_reserves_name_1_in_top_level_scope_of_a_module, scanner.DeclarationNameToString(name), scanner.DeclarationNameToString(name))
 	}
 }
 
@@ -13323,6 +13325,12 @@ func (c *Checker) error(location *ast.Node, message *diagnostics.Message, args .
 	return diagnostic
 }
 
+func (c *Checker) errorSkippedOnNoEmit(location *ast.Node, message *diagnostics.Message, args ...any) *ast.Diagnostic {
+	diagnostic := c.error(location, message, args...)
+	diagnostic.SetSkippedOnNoEmit()
+	return diagnostic
+}
+
 func (c *Checker) errorOrSuggestion(isError bool, location *ast.Node, message *diagnostics.Message, args ...any) {
 	c.addErrorOrSuggestion(isError, NewDiagnosticForNode(location, message, args...))
 }
@@ -14808,6 +14816,17 @@ func (c *Checker) tryFindAmbientModule(moduleName string, withAugmentations bool
 	return symbol
 }
 
+func (c *Checker) GetAmbientModules() []*ast.Symbol {
+	c.ambientModulesOnce.Do(func() {
+		for sym, global := range c.globals {
+			if strings.HasPrefix(sym, "\"") && strings.HasSuffix(sym, "\"") {
+				c.ambientModules = append(c.ambientModules, global)
+			}
+		}
+	})
+	return c.ambientModules
+}
+
 func (c *Checker) resolveExternalModuleSymbol(moduleSymbol *ast.Symbol, dontResolveAlias bool) *ast.Symbol {
 	if moduleSymbol != nil {
 		exportEquals := c.resolveSymbolEx(moduleSymbol.Exports[ast.InternalSymbolNameExportEquals], dontResolveAlias)

internal/checker/checker_test.go

@@ -36,7 +36,7 @@ foo.bar;`
 	fs = bundled.WrapFS(fs)
 
 	cd := "/"
-	host := compiler.NewCompilerHost(cd, fs, bundled.LibPath())
+	host := compiler.NewCompilerHost(cd, fs, bundled.LibPath(), nil)
 
 	parsed, errors := tsoptions.GetParsedCommandLineOfConfigFile("/tsconfig.json", &core.CompilerOptions{}, host, nil)
 	assert.Equal(t, len(errors), 0, "Expected no errors in parsed command line")
@@ -70,14 +70,14 @@ func TestCheckSrcCompiler(t *testing.T) {
 
 	rootPath := tspath.CombinePaths(tspath.NormalizeSlashes(repo.TypeScriptSubmodulePath), "src", "compiler")
 
-	host := compiler.NewCompilerHost(rootPath, fs, bundled.LibPath())
+	host := compiler.NewCompilerHost(rootPath, fs, bundled.LibPath(), nil)
 	parsed, errors := tsoptions.GetParsedCommandLineOfConfigFile(tspath.CombinePaths(rootPath, "tsconfig.json"), &core.CompilerOptions{}, host, nil)
 	assert.Equal(t, len(errors), 0, "Expected no errors in parsed command line")
 	p := compiler.NewProgram(compiler.ProgramOptions{
 		Config: parsed,
 		Host:   host,
 	})
-	p.CheckSourceFiles(t.Context())
+	p.CheckSourceFiles(t.Context(), nil)
 }
 
 func BenchmarkNewChecker(b *testing.B) {
@@ -87,7 +87,7 @@ func BenchmarkNewChecker(b *testing.B) {
 
 	rootPath := tspath.CombinePaths(tspath.NormalizeSlashes(repo.TypeScriptSubmodulePath), "src", "compiler")
 
-	host := compiler.NewCompilerHost(rootPath, fs, bundled.LibPath())
+	host := compiler.NewCompilerHost(rootPath, fs, bundled.LibPath(), nil)
 	parsed, errors := tsoptions.GetParsedCommandLineOfConfigFile(tspath.CombinePaths(rootPath, "tsconfig.json"), &core.CompilerOptions{}, host, nil)
 	assert.Equal(b, len(errors), 0, "Expected no errors in parsed command line")
 	p := compiler.NewProgram(compiler.ProgramOptions{

internal/checker/grammarchecks.go

@@ -42,6 +42,17 @@ func (c *Checker) grammarErrorOnNode(node *ast.Node, message *diagnostics.Messag
 	return false
 }
 
+func (c *Checker) grammarErrorOnNodeSkippedOnNoEmit(node *ast.Node, message *diagnostics.Message, args ...any) bool {
+	sourceFile := ast.GetSourceFileOfNode(node)
+	if !c.hasParseDiagnostics(sourceFile) {
+		d := NewDiagnosticForNode(node, message, args...)
+		d.SetSkippedOnNoEmit()
+		c.diagnostics.Add(d)
+		return true
+	}
+	return false
+}
+
 func (c *Checker) checkGrammarRegularExpressionLiteral(_ *ast.RegularExpressionLiteral) bool {
 	// !!!
 	// Unclear if this is needed until regular expression parsing is more thoroughly implemented.
@@ -1648,7 +1659,7 @@ func (c *Checker) checkGrammarVariableDeclaration(node *ast.VariableDeclaration)
 func (c *Checker) checkGrammarForEsModuleMarkerInBindingName(name *ast.Node) bool {
 	if ast.IsIdentifier(name) {
 		if name.Text() == "__esModule" {
-			return c.grammarErrorOnNode(name, diagnostics.Identifier_expected_esModule_is_reserved_as_an_exported_marker_when_transforming_ECMAScript_modules)
+			return c.grammarErrorOnNodeSkippedOnNoEmit(name, diagnostics.Identifier_expected_esModule_is_reserved_as_an_exported_marker_when_transforming_ECMAScript_modules)
 		}
 	} else {
 		for _, element := range name.AsBindingPattern().Elements.Nodes {

internal/checker/symbolaccessibility.go

@@ -105,11 +105,7 @@ func (ch *Checker) IsAnySymbolAccessible(symbols []*ast.Symbol, enclosingDeclara
 }
 
 func hasNonGlobalAugmentationExternalModuleSymbol(declaration *ast.Node) bool {
-	return isModuleWithStringLiteralName(declaration) || (declaration.Kind == ast.KindSourceFile && ast.IsExternalOrCommonJSModule(declaration.AsSourceFile()))
-}
-
-func isModuleWithStringLiteralName(node *ast.Node) bool {
-	return ast.IsModuleDeclaration(node) && node.Name().Kind == ast.KindStringLiteral
+	return ast.IsModuleWithStringLiteralName(declaration) || (declaration.Kind == ast.KindSourceFile && ast.IsExternalOrCommonJSModule(declaration.AsSourceFile()))
 }
 
 func getQualifiedLeftMeaning(rightMeaning ast.SymbolFlags) ast.SymbolFlags {

internal/checker/utilities.go

@@ -1460,8 +1460,8 @@ func forEachYieldExpression(body *ast.Node, visitor func(expr *ast.Node)) {
 	traverse(body)
 }
 
-func SkipTypeChecking(sourceFile *ast.SourceFile, options *core.CompilerOptions, host Program) bool {
-	return options.NoCheck.IsTrue() ||
+func SkipTypeChecking(sourceFile *ast.SourceFile, options *core.CompilerOptions, host Program, ignoreNoCheck bool) bool {
+	return (!ignoreNoCheck && options.NoCheck.IsTrue()) ||
 		options.SkipLibCheck.IsTrue() && sourceFile.IsDeclarationFile ||
 		options.SkipDefaultLibCheck.IsTrue() && host.IsSourceFileDefaultLibrary(sourceFile.Path()) ||
 		host.IsSourceFromProjectReference(sourceFile.Path()) ||

internal/collections/manytomanyset.go

@@ -0,0 +1,49 @@
+package collections
+
+import "fmt"
+
+type ManyToManySet[K comparable, V comparable] struct {
+	keyToValueSet map[K]*Set[V]
+	valueToKeySet map[V]*Set[K]
+}
+
+func (m *ManyToManySet[K, V]) GetKeys(value V) (*Set[K], bool) {
+	keys, present := m.valueToKeySet[value]
+	return keys, present
+}
+
+func (m *ManyToManySet[K, V]) GetValues(key K) (*Set[V], bool) {
+	values, present := m.keyToValueSet[key]
+	return values, present
+}
+
+func (m *ManyToManySet[K, V]) Len() int {
+	return len(m.keyToValueSet)
+}
+
+func (m *ManyToManySet[K, V]) Keys() map[K]*Set[V] {
+	return m.keyToValueSet
+}
+
+func (m *ManyToManySet[K, V]) Set(key K, valueSet *Set[V]) {
+	_, hasExisting := m.keyToValueSet[key]
+	if hasExisting {
+		panic("ManyToManySet.Set: key already exists: " + fmt.Sprintf("%v", key))
+	}
+	if m.keyToValueSet == nil {
+		m.keyToValueSet = make(map[K]*Set[V])
+	}
+	m.keyToValueSet[key] = valueSet
+	for value := range valueSet.Keys() {
+		// Add to valueToKeySet
+		keySetForValue, exists := m.valueToKeySet[value]
+		if !exists {
+			if m.valueToKeySet == nil {
+				m.valueToKeySet = make(map[V]*Set[K])
+			}
+			keySetForValue = &Set[K]{}
+			m.valueToKeySet[value] = keySetForValue
+		}
+		keySetForValue.Add(key)
+	}
+}

internal/collections/set.go

@@ -1,5 +1,7 @@
 package collections
 
+import "maps"
+
 type Set[T comparable] struct {
 	M map[T]struct{}
 }
@@ -48,6 +50,24 @@ func (s *Set[T]) AddIfAbsent(key T) bool {
 	return true
 }
 
+func (s *Set[T]) Clone() *Set[T] {
+	if s == nil {
+		return nil
+	}
+	clone := &Set[T]{M: maps.Clone(s.M)}
+	return clone
+}
+
+func (s *Set[T]) Equals(other *Set[T]) bool {
+	if s == other {
+		return true
+	}
+	if s == nil || other == nil {
+		return false
+	}
+	return maps.Equal(s.M, other.M)
+}
+
 func NewSetFromItems[T comparable](items ...T) *Set[T] {
 	s := &Set[T]{}
 	for _, item := range items {