Conversation
Co-authored-by: osortega <48293249+osortega@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds product icons to the Welcome-related editor tabs so they display an icon consistent with other editor tabs (stable vs Insiders variant).
Changes:
- Added
getIcon()override toGettingStartedInputto return a VS Code product codicon based on build quality. - Added
getIcon()override toAgentSessionsWelcomeInputto return a VS Code product codicon based on build quality.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStartedInput.ts | Adds getIcon() so the main Welcome/Getting Started tab shows a product icon. |
| src/vs/workbench/contrib/welcomeAgentSessions/browser/agentSessionsWelcomeInput.ts | Adds getIcon() so the Agent Sessions Welcome tab shows a product icon. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 2
| } | ||
|
|
||
| override getIcon(): ThemeIcon { | ||
| return product.quality === 'stable' ? Codicon.vscode : Codicon.vscodeInsiders; |
There was a problem hiding this comment.
product.quality is optional (it’s not set in this repo’s product.json for Code - OSS). With the current ternary, an undefined quality will fall through to the Insiders icon, so OSS/dev builds would show the wrong tab icon. Consider handling undefined (and/or code-oss) explicitly so the icon matches the actual product variant.
| return product.quality === 'stable' ? Codicon.vscode : Codicon.vscodeInsiders; | |
| return product.quality === 'insider' ? Codicon.vscodeInsiders : Codicon.vscode; |
| } | ||
|
|
||
| override getIcon(): ThemeIcon { | ||
| return product.quality === 'stable' ? Codicon.vscode : Codicon.vscodeInsiders; |
There was a problem hiding this comment.
product.quality is optional (e.g. Code - OSS product.json doesn’t set it). As written, undefined quality will select the Insiders icon, which likely produces an incorrect tab icon for OSS/dev builds. Consider an explicit fallback for undefined (and/or mapping code-oss to the appropriate product icon).
| return product.quality === 'stable' ? Codicon.vscode : Codicon.vscodeInsiders; | |
| return product.quality === 'insider' ? Codicon.vscodeInsiders : Codicon.vscode; |
|
lgtm |
Welcome page tabs displayed without icons while other editor tabs show the appropriate product icon (VS Code stable or Insiders variant).
Changes
Added
getIcon()override to both Welcome page editor inputs:Files modified:
GettingStartedInput- Getting Started/Welcome pageAgentSessionsWelcomeInput- Agent Sessions Welcome pageBoth now return the correct product icon based on build quality.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
github-production-user-asset-6210df.s3.amazonaws.com/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.