code review

Author: soyuka

src/Capability/Discovery/SchemaGenerator.php

@@ -12,6 +12,7 @@
 namespace Mcp\Capability\Discovery;
 
 use Mcp\Capability\Attribute\Schema;
+use Mcp\Exception\BadMethodCallException;
 use Mcp\Exception\InvalidArgumentException;
 use Mcp\Server\RequestContext;
 use phpDocumentor\Reflection\DocBlock\Tags\Param;
@@ -71,11 +72,11 @@ public function __construct(
     public function generate(\Reflector $reflection): array
     {
         if ($reflection instanceof \ReflectionClass) {
-            throw new \BadMethodCallException('Schema generation from ReflectionClass is not implemented yet. Use ReflectionMethod or ReflectionFunction instead.');
+            throw new BadMethodCallException('Schema generation from ReflectionClass is not implemented yet. Use ReflectionMethod or ReflectionFunction instead.');
         }
 
         if (!$reflection instanceof \ReflectionMethod && !$reflection instanceof \ReflectionFunction) {
-            throw new \BadMethodCallException(\sprintf('Schema generation from %s is not supported. Use ReflectionMethod or ReflectionFunction instead.', $reflection::class));
+            throw new BadMethodCallException(\sprintf('Schema generation from %s is not supported. Use ReflectionMethod or ReflectionFunction instead.', $reflection::class));
         }
 
         $methodSchema = $this->extractMethodLevelSchema($reflection);

src/Exception/BadMethodCallException.php

@@ -0,0 +1,19 @@
+<?php
+
+/*
+ * This file is part of the official PHP MCP SDK.
+ *
+ * A collaboration between Symfony and the PHP Foundation.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Mcp\Exception;
+
+/**
+ * @author Antoine Bluchet <soyuka@gmail.com>
+ */
+final class BadMethodCallException extends \BadMethodCallException implements ExceptionInterface
+{
+}

src/Server/Builder.php

@@ -11,6 +11,8 @@
 
 namespace Mcp\Server;
 
+use Mcp\Capability\Discovery\CachedDiscoverer;
+use Mcp\Capability\Discovery\Discoverer;
 use Mcp\Capability\Discovery\DiscovererInterface;
 use Mcp\Capability\Discovery\SchemaGeneratorInterface;
 use Mcp\Capability\Registry;
@@ -551,10 +553,10 @@ public function build(): Server
 
     private function createDiscoverer(LoggerInterface $logger): DiscovererInterface
     {
-        $discoverer = new \Mcp\Capability\Discovery\Discoverer($logger, null, $this->schemaGenerator);
+        $discoverer = new Discoverer($logger, null, $this->schemaGenerator);
 
         if (null !== $this->discoveryCache) {
-            return new \Mcp\Capability\Discovery\CachedDiscoverer($discoverer, $this->discoveryCache, $logger);
+            return new CachedDiscoverer($discoverer, $this->discoveryCache, $logger);
         }
 
         return $discoverer;