Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/core/src/shared/protocol.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1010,7 +1010,10 @@ export abstract class Protocol<ContextT extends BaseContext> {
// A notification can only be debounced if it's in the list AND it's "simple"
// (i.e., has no parameters and no related request ID or related task that could be lost).
const canDebounce =
debouncedMethods.includes(notification.method) && !notification.params && !options?.relatedRequestId && !options?.relatedTask;
debouncedMethods.includes(notification.method) &&
!notification.params &&
options?.relatedRequestId == null &&
!options?.relatedTask;

if (canDebounce) {
// If a notification of this type is already scheduled, do nothing.
Expand Down
16 changes: 16 additions & 0 deletions packages/core/test/shared/protocol.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -768,6 +768,22 @@ describe('protocol tests', () => {
expect(sendSpy).toHaveBeenCalledWith(expect.any(Object), { relatedRequestId: 'req-2' });
});

it('should NOT debounce a notification that has relatedRequestId 0 (regression for #2117)', async () => {
// ARRANGE: id=0 is a valid JSON-RPC RequestId (and the first id a Protocol uses).
// The truthy guard `!options?.relatedRequestId` treated 0 as absent and
// incorrectly debounced these related notifications. Pin the fixed behaviour.
protocol = new TestProtocolImpl({ debouncedNotificationMethods: ['test/debounced_with_options'] });
await protocol.connect(transport);

// ACT
await protocol.notification({ method: 'test/debounced_with_options' }, { relatedRequestId: 0 });
await protocol.notification({ method: 'test/debounced_with_options' }, { relatedRequestId: 0 });

// ASSERT: both calls must reach the transport (no coalescing).
expect(sendSpy).toHaveBeenCalledTimes(2);
expect(sendSpy).toHaveBeenCalledWith(expect.any(Object), { relatedRequestId: 0 });
});

it('should clear pending debounced notifications on connection close', async () => {
// ARRANGE
protocol = new TestProtocolImpl({ debouncedNotificationMethods: ['test/debounced'] });
Expand Down
Loading