PHPC-1431: Accept null for Session::startTransaction() options

jmikola · jmikola · commit 743eaaf24696 · 2019-08-29T10:44:57.000-04:00
diff --git a/src/MongoDB/Session.c b/src/MongoDB/Session.c
@@ -367,7 +367,7 @@ static PHP_METHOD(Session, startTransaction)
 	intern = Z_SESSION_OBJ_P(getThis());
 	SESSION_CHECK_LIVELINESS(intern, "startTransaction")
 
-	if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "|a", &options) == FAILURE) {
+	if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "|a!", &options) == FAILURE) {
 		return;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -367,7 +367,7 @@ static PHP_METHOD(Session, startTransaction)`
`367`	`367`	`intern = Z_SESSION_OBJ_P(getThis());`
`368`	`368`	`SESSION_CHECK_LIVELINESS(intern, "startTransaction")`
`369`	`369`
`370`		`- if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "\|a", &options) == FAILURE) {`
	`370`	`+ if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "\|a!", &options) == FAILURE) {`
`371`	`371`	`return;`
`372`	`372`	`}`
`373`	`373`