From c30fc1de55687c34b7f8e374c025b8af3b86a1f6 Mon Sep 17 00:00:00 2001 From: Leonabcd123 <156839416+Leonabcd123@users.noreply.github.com> Date: Wed, 10 Jun 2026 20:57:38 +0300 Subject: [PATCH 1/4] fix(quote-filter): custom filter modal opening when it shouldn't --- frontend/src/ts/components/modals/QuoteSearchModal.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/frontend/src/ts/components/modals/QuoteSearchModal.tsx b/frontend/src/ts/components/modals/QuoteSearchModal.tsx index 35e26fbd9dfb..a2f8a24bf3df 100644 --- a/frontend/src/ts/components/modals/QuoteSearchModal.tsx +++ b/frontend/src/ts/components/modals/QuoteSearchModal.tsx @@ -348,7 +348,9 @@ export function QuoteSearchModal(): JSXElement { createEffect( on(lengthFilter, (lengths) => { - if (lengths.includes("4") && !hasCustomFilter()) { + if (!lengths.includes("4")) { + setHasCustomFilter(false); + } else if (!hasCustomFilter()) { showSimpleModal({ title: "Enter minimum and maximum number of words", buttonText: "save", From 9bc5fb9fde740223d5ffb6d97bd299ef1913678f Mon Sep 17 00:00:00 2001 From: Leonabcd123 <156839416+Leonabcd123@users.noreply.github.com> Date: Fri, 12 Jun 2026 15:17:43 +0300 Subject: [PATCH 2/4] Better --- frontend/src/ts/components/modals/QuoteSearchModal.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/frontend/src/ts/components/modals/QuoteSearchModal.tsx b/frontend/src/ts/components/modals/QuoteSearchModal.tsx index a2f8a24bf3df..941d1aac70a0 100644 --- a/frontend/src/ts/components/modals/QuoteSearchModal.tsx +++ b/frontend/src/ts/components/modals/QuoteSearchModal.tsx @@ -349,7 +349,9 @@ export function QuoteSearchModal(): JSXElement { createEffect( on(lengthFilter, (lengths) => { if (!lengths.includes("4")) { - setHasCustomFilter(false); + if (hasCustomFilter()) { + setHasCustomFilter(false); + } } else if (!hasCustomFilter()) { showSimpleModal({ title: "Enter minimum and maximum number of words", From 6e011bdd20b0d46a45babe7d9d76b5a829e25c21 Mon Sep 17 00:00:00 2001 From: Leonabcd123 <156839416+Leonabcd123@users.noreply.github.com> Date: Fri, 12 Jun 2026 15:19:06 +0300 Subject: [PATCH 3/4] Revert "Better" This reverts commit 9bc5fb9fde740223d5ffb6d97bd299ef1913678f. --- frontend/src/ts/components/modals/QuoteSearchModal.tsx | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/frontend/src/ts/components/modals/QuoteSearchModal.tsx b/frontend/src/ts/components/modals/QuoteSearchModal.tsx index 941d1aac70a0..a2f8a24bf3df 100644 --- a/frontend/src/ts/components/modals/QuoteSearchModal.tsx +++ b/frontend/src/ts/components/modals/QuoteSearchModal.tsx @@ -349,9 +349,7 @@ export function QuoteSearchModal(): JSXElement { createEffect( on(lengthFilter, (lengths) => { if (!lengths.includes("4")) { - if (hasCustomFilter()) { - setHasCustomFilter(false); - } + setHasCustomFilter(false); } else if (!hasCustomFilter()) { showSimpleModal({ title: "Enter minimum and maximum number of words", From d9af07d9ff0e9d16ff3dafa410a7a99240b08a3a Mon Sep 17 00:00:00 2001 From: Leonabcd123 <156839416+Leonabcd123@users.noreply.github.com> Date: Fri, 12 Jun 2026 15:22:18 +0300 Subject: [PATCH 4/4] Remove notification --- frontend/src/ts/components/modals/QuoteSearchModal.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/src/ts/components/modals/QuoteSearchModal.tsx b/frontend/src/ts/components/modals/QuoteSearchModal.tsx index a2f8a24bf3df..641416f72a32 100644 --- a/frontend/src/ts/components/modals/QuoteSearchModal.tsx +++ b/frontend/src/ts/components/modals/QuoteSearchModal.tsx @@ -367,7 +367,7 @@ export function QuoteSearchModal(): JSXElement { setCustomFilterMin(min); setCustomFilterMax(max); setHasCustomFilter(true); - return { status: "success", message: "Saved custom filter" }; + return { status: "success", showNotification: false }; }, }); }