Improve picker test and rename RPCPlatform tests

Author: nexcode

internal/balancer/picker/picker_test.go

@@ -29,7 +29,7 @@ import (
 	"google.golang.org/grpc/resolver"
 )
 
-func TestNew(t *testing.T) {
+func TestPicker(t *testing.T) {
 	t.Parallel()
 
 	childStates := []endpointsharding.ChildState{{
@@ -105,10 +105,24 @@ func TestNew(t *testing.T) {
 	}
 
 	picker := New(childStates, config).(*picker)
-
 	actualSequence := make([]int, len(picker.pickers))
-	for i, picker := range picker.pickers {
-		actualSequence[i] = picker.(*namedPicker).name
+	pickerNext := picker.next
+
+	for i, childPicker := range picker.pickers {
+		actualSequence[i] = childPicker.(*namedPicker).name
+
+		if _, err := picker.Pick(balancer.PickInfo{}); err != nil {
+			t.Fatalf("Pick() failed: %v", err)
+		}
+
+		pickerNext++
+		if pickerNext == len(picker.pickers) {
+			pickerNext = 0
+		}
+
+		if picker.next != pickerNext {
+			t.Errorf("picker next = %v, want: %v", picker.next, pickerNext)
+		}
 	}
 
 	expectedSequence := []int{2, 3, 4, 2, 3, 2, 2, 3, 4, 2, 3, 2, 2, 3, 4}

rpcplatform_test.go

@@ -154,7 +154,7 @@ func TestNew(t *testing.T) {
 	}
 }
 
-func TestLookup(t *testing.T) {
+func TestRPCPlatform_Lookup(t *testing.T) {
 	t.Parallel()
 
 	etcdClient := getEtcdClient(t)
@@ -216,7 +216,7 @@ func TestLookup(t *testing.T) {
 	t.Errorf("channel closed by timeout or unexpectedly")
 }
 
-func TestNewClient(t *testing.T) {
+func TestRPCPlatform_NewClient(t *testing.T) {
 	t.Parallel()
 
 	insecureTransport := PlatformOptions.ClientOptions(
@@ -339,7 +339,7 @@ func TestNewClient(t *testing.T) {
 	}
 }
 
-func TestNewServer(t *testing.T) {
+func TestRPCPlatform_NewServer(t *testing.T) {
 	t.Parallel()
 
 	type input struct {