Move file after chunked upload instead of copying

[giomf]

Tip

Help move this idea forward

• Use the 👍 reaction to show support for this feature.
• Avoid commenting unless you have relevant information to add; unnecessary comments create noise for subscribers.
• Subscribe to receive notifications about status changes and new comments.

---

Is your feature request related to a problem? Please describe.

MOVE Operation of chunked upload copies file from staging area to destination instead of moving it.
This can lead to timeouts or delays the whole upload process.

Describe the solution you'd like

When the staging area and the destination are on the same partition, using move instead of copy could speed up the upload.

Additional context

Im not a php developer but tried to dig a little deeper.

In ChuningV2Plugin.php i can see how it distinguish between move and copy based on the fact if the file already exists. This does not cover my observation though. I uploaded a new file and it was copied in the end.
In fact tried to upload it first but it ran into a timeout. I increased the timeout and tried it again. Maybe the database entry was still there?

Also, what is the reason to copy to destination if the file already exists? Maybe to preserve the internal ID of the file in database?
Maybe anybody with more context can give insights here.

[susnux]

Also, what is the reason to copy to destination if the file already exists? Maybe to preserve the internal ID of the file in database?

The reason is that if you have a quota applied you do not know if the final assembled file will fit into that quota.
So it is copied and only if that worked the original file is removed. This is needed as when it does not fit we need to rollback to the "old" file you would otherwise override.

cc @provokateurin

[giomf]

Oh ok, I thought that quota related stuff will happen before uploading...

[susnux]

I thought that quota related stuff will happen before uploading...

Yes but we also need to verify on server, it cannot just happen in the frontend as this is also used by clients etc and we also need to account for buggy / malicious clients. So validation has to happen on the backend.