sqlite: improve error for excess bound parameters

Signed-off-by: Lazizbek Ergashev <lazerg2@gmail.com>

Author: lazerg

doc/api/sqlite.md

@@ -1034,6 +1034,9 @@ Binding a key that does not name a parameter of the statement throws an
 `ERR_INVALID_STATE` error unless unknown named parameters are ignored. See
 [`statement.setAllowUnknownNamedParameters()`][].
 
+Passing more anonymous parameters than the statement has also throws an
+`ERR_INVALID_STATE` error.
+
 See [Type conversion between JavaScript and SQLite][] for the values that can be
 bound. Binding any other value throws an `ERR_INVALID_ARG_TYPE` error.
 

src/node_sqlite.cc

@@ -2777,13 +2777,25 @@ bool StatementSync::BindParams(const FunctionCallbackInfo<Value>& args) {
     anon_start++;
   }
 
+  int param_count = sqlite3_bind_parameter_count(statement_);
+
   for (int i = anon_start; i < args.Length(); ++i) {
-    while (1) {
+    while (anon_idx <= param_count) {
       const char* param = sqlite3_bind_parameter_name(statement_, anon_idx);
       if (param == nullptr || param[0] == '?') break;
       anon_idx++;
     }
 
+    if (anon_idx > param_count) {
+      THROW_ERR_INVALID_STATE(
+          env(),
+          "Too many parameter values were provided. The statement accepts "
+          "%d, but received %d",
+          i - anon_start,
+          args.Length() - anon_start);
+      return false;
+    }
+
     if (!BindValue(args[i], anon_idx)) {
       return false;
     }

test/parallel/test-sqlite-statement-sync.js

@@ -337,7 +337,7 @@ suite('StatementSync.prototype.run()', () => {
     t.assert.deepStrictEqual(stmt.run(), { changes: 1, lastInsertRowid: 1 });
   });
 
-  test('SQLite throws when trying to bind too many parameters', (t) => {
+  test('throws when trying to bind too many parameters', (t) => {
     const db = new DatabaseSync(':memory:');
     t.after(() => { db.close(); });
     const setup = db.exec(
@@ -348,10 +348,25 @@ suite('StatementSync.prototype.run()', () => {
     t.assert.throws(() => {
       stmt.run(1, 2, 3);
     }, {
-      code: 'ERR_SQLITE_ERROR',
-      message: 'column index out of range',
-      errcode: 25,
-      errstr: 'column index out of range',
+      code: 'ERR_INVALID_STATE',
+      message: 'Too many parameter values were provided. ' +
+               'The statement accepts 2, but received 3',
+    });
+
+    t.assert.throws(() => {
+      db.prepare('SELECT 1').get(5);
+    }, {
+      code: 'ERR_INVALID_STATE',
+      message: 'Too many parameter values were provided. ' +
+               'The statement accepts 0, but received 1',
+    });
+
+    t.assert.throws(() => {
+      db.prepare('SELECT $a AS a, ? AS b').get({ $a: 1 }, 2, 3);
+    }, {
+      code: 'ERR_INVALID_STATE',
+      message: 'Too many parameter values were provided. ' +
+               'The statement accepts 1, but received 2',
     });
   });