Remove unreachable workdir check in unzipIPA

Author: radare

index.ts

@@ -876,17 +876,17 @@ class Applesign {
     }
   }
 
-  async unzipIPA(file: any, workdir: any): Promise<any> {
+  async unzipIPA(file: string, workdir: string): Promise<void> {
     fchk(arguments, ["string", "string"]);
-    if (!file || !workdir) {
-      throw new Error("No output specified");
+    if (!file) {
+      throw new Error("No input file specified");
     }
     if (!workdir) {
-      throw new Error("Invalid output directory");
+      throw new Error("No output directory specified");
     }
     await this.cleanup();
     this.events.emit("message", "Unzipping " + file);
-    return tools.unzip(file, workdir);
+    await tools.unzip(file, workdir);
   }
 
   /* Event Wrapper API with cb support */

lib/version.ts

@@ -1,2 +1,2 @@
-const version = "5.0.1";
+const version = "6.0.0";
 export default version;

test/test.ts

@@ -3,6 +3,7 @@ import { spawn } from "node:child_process";
 import * as path from "node:path";
 import * as fs from "node:fs";
 import { describe, it } from "mocha";
+import Applesign from "../index.js";
 
 const mochaTimeout = 15000;
 const developerCertificate = process.env.DEVCERT;
@@ -25,6 +26,26 @@ describe("API", () => {
 });
 */
 
+describe("API", () => {
+  describe("unzipIPA", () => {
+    it("should fail when the input file is missing", async () => {
+      const applesign = new Applesign({});
+      await assert.rejects(
+        applesign.unzipIPA("", "tmp"),
+        /No input file specified/,
+      );
+    });
+
+    it("should fail when the output directory is missing", async () => {
+      const applesign = new Applesign({});
+      await assert.rejects(
+        applesign.unzipIPA("test.ipa", ""),
+        /No output directory specified/,
+      );
+    });
+  });
+});
+
 describe("Commandline", () => {
   describe("dist/bin/applesign.js", () => {
     it("should fail when applesign cannot be executed", (done) => {