chore(build-logic): complete version catalogue and build logic setup

- Add missing dependencies to version catalogue
- Finalize build logic configuration

Author: amanna13

build-logic/convention/build.gradle.kts

@@ -59,15 +59,15 @@ gradlePlugin {
             implementationClass = "AndroidTestConventionPlugin"
         }
         register("androidFirebase") {
-            id = "mifos.android.application.firebase"
+            id = "org.convention.android.application.firebase"
             implementationClass = "AndroidApplicationFirebaseConventionPlugin"
         }
         register("androidFlavors") {
             id = "mifos.android.application.flavors"
             implementationClass = "AndroidApplicationFlavorsConventionPlugin"
         }
         register("androidLint") {
-            id = "mifos.android.lint"
+            id = "org.convention.android.application.lint"
             implementationClass = "AndroidLintConventionPlugin"
         }
         register("jvmLibrary") {
@@ -97,15 +97,15 @@ gradlePlugin {
 
         // KMP & CMP Plugins
         register("cmpFeature") {
-            id = "mifos.cmp.feature"
+            id = "org.convention.cmp.feature"
             implementationClass = "CMPFeatureConventionPlugin"
         }
         register("kmpKoin") {
-            id = "mifos.kmp.koin"
+            id = "org.convention.kmp.koin"
             implementationClass = "KMPKoinConventionPlugin"
         }
         register("kmpLibrary") {
-            id = "mifos.kmp.library"
+            id = "org.convention.kmp.library"
             implementationClass = "KMPLibraryConventionPlugin"
         }
 

build-logic/convention/src/main/kotlin/AndroidApplicationConventionPlugin.kt

@@ -16,12 +16,13 @@ class AndroidApplicationConventionPlugin : Plugin<Project> {
             with(pluginManager) {
                 apply("com.android.application")
                 apply("org.jetbrains.kotlin.android")
-                apply("mifos.android.lint")
                 apply("com.dropbox.dependency-guard")
                 apply("mifos.detekt.plugin")
                 apply("mifos.spotless.plugin")
                 apply("mifos.ktlint.plugin")
-//                apply("mifos.git.hooks")
+                apply("mifos.git.hooks")
+                apply("org.convention.android.application.lint")
+//                apply("org.convention.android.application.firebase")
             }
 
             extensions.configure<ApplicationExtension> {

build-logic/convention/src/main/kotlin/AndroidApplicationFirebaseConventionPlugin.kt

@@ -25,11 +25,13 @@ class AndroidApplicationFirebaseConventionPlugin : Plugin<Project> {
             }
 
             extensions.configure<ApplicationExtension> {
-                // Disable the Crashlytics mapping file upload. This feature should only be
-                // enabled if a Firebase backend is available and configured in
-                // google-services.json.
-                configure<CrashlyticsExtension> {
-                    mappingFileUploadEnabled = false
+                buildTypes.configureEach {
+                    // Disable the Crashlytics mapping file upload. This feature should only be
+                    // enabled if a Firebase backend is available and configured in
+                    // google-services.json.
+                    configure<CrashlyticsExtension> {
+                        mappingFileUploadEnabled = false
+                    }
                 }
             }
         }

build-logic/convention/src/main/kotlin/AndroidLintConventionPlugin.kt

@@ -30,7 +30,7 @@ private fun Lint.configure() {
     checkDependencies = true
     abortOnError = false
     // Disable this rule until we ship the libraries to some maven.
-    disable += "ResourceName"
+    disable += "GradleDependency"
     baseline = File("lint-baseline.xml")
     explainIssues = true
     htmlReport = true

build-logic/convention/src/main/kotlin/CMPFeatureConventionPlugin.kt

@@ -8,8 +8,8 @@ class CMPFeatureConventionPlugin : Plugin<Project> {
     override fun apply(target: Project) {
         with(target) {
             with(pluginManager) {
-                apply("mifos.kmp.library")
-                apply("mifos.kmp.koin")
+                apply("org.convention.kmp.library")
+                apply("org.convention.kmp.koin")
                 apply("org.jetbrains.kotlin.plugin.compose")
                 apply("org.jetbrains.compose")
             }

build-logic/convention/src/main/kotlin/FieldSkippingClassVisitor.kt

@@ -0,0 +1,47 @@
+import com.android.build.api.instrumentation.AsmClassVisitorFactory
+import com.android.build.api.instrumentation.ClassContext
+import com.android.build.api.instrumentation.ClassData
+import com.android.build.api.instrumentation.InstrumentationParameters
+import org.gradle.api.provider.SetProperty
+import org.gradle.api.tasks.Input
+import org.objectweb.asm.ClassVisitor
+import org.objectweb.asm.FieldVisitor
+
+class FieldSkippingClassVisitor(
+    apiVersion: Int,
+    nextClassVisitor: ClassVisitor,
+) : ClassVisitor(apiVersion, nextClassVisitor) {
+
+    // Returning null from this method will cause the ClassVisitor to strip all fields from the class.
+    override fun visitField(
+        access: Int,
+        name: String?,
+        descriptor: String?,
+        signature: String?,
+        value: Any?
+    ): FieldVisitor? = null
+
+    abstract class Factory : AsmClassVisitorFactory<Parameters> {
+
+        private val excludedClasses
+            get() = parameters.get().classes.get()
+
+        override fun isInstrumentable(classData: ClassData): Boolean =
+            classData.className in excludedClasses
+
+        override fun createClassVisitor(
+            classContext: ClassContext,
+            nextClassVisitor: ClassVisitor,
+        ): ClassVisitor {
+            return FieldSkippingClassVisitor(
+                apiVersion = instrumentationContext.apiVersion.get(),
+                nextClassVisitor = nextClassVisitor,
+            )
+        }
+    }
+
+    abstract class Parameters : InstrumentationParameters {
+        @get:Input
+        abstract val classes: SetProperty<String>
+    }
+}

build-logic/convention/src/main/kotlin/KMPLibraryConventionPlugin.kt

@@ -15,7 +15,7 @@ class KMPLibraryConventionPlugin : Plugin<Project> {
             with(pluginManager) {
                 apply("com.android.library")
                 apply("org.jetbrains.kotlin.multiplatform")
-                apply("mifos.kmp.koin")
+                apply("org.convention.kmp.koin")
                 apply("mifos.detekt.plugin")
                 apply("mifos.spotless.plugin")
             }

build-logic/convention/src/main/kotlin/MifosGitHooksConventionPlugin.kt

@@ -0,0 +1,57 @@
+
+import org.gradle.api.Plugin
+import org.gradle.api.Project
+import org.gradle.api.tasks.Copy
+import org.gradle.api.tasks.Exec
+import org.gradle.kotlin.dsl.register
+import java.util.Locale
+
+/**
+ * Plugin that installs the pre-commit git hooks from the scripts directory.
+ */
+class MifosGitHooksConventionPlugin : Plugin<Project> {
+    override fun apply(project: Project) {
+        // Define a function to check if the OS is Linux or MacOS
+        fun isLinuxOrMacOs(): Boolean {
+            val osName = System.getProperty("os.name").lowercase(Locale.getDefault())
+            return osName.contains("linux") || osName.contains("mac os") || osName.contains("macos")
+        }
+
+        // Define the copyGitHooks task
+        project.tasks.register<Copy>("copyGitHooks") {
+            description = "Copies the git hooks from /scripts to the .git/hooks folder."
+            from("${project.rootDir}/scripts/") {
+                include("**/*.sh")
+                rename { it.removeSuffix(".sh") }
+            }
+            into("${project.rootDir}/.git/hooks")
+        }
+
+        // Define the installGitHooks task
+        project.tasks.register<Exec>("installGitHooks") {
+            description = "Installs the pre-commit git hooks from the scripts directory."
+            group = "git hooks"
+            workingDir = project.rootDir
+
+            if (isLinuxOrMacOs()) {
+                commandLine("chmod", "-R", "+x", ".git/hooks/")
+            }else {
+                commandLine("cmd", "/c", "attrib", "-R", "+X", ".git/hooks/*.*")
+            }
+            dependsOn(project.tasks.named("copyGitHooks"))
+
+            doLast {
+                println("Git hooks installed successfully.")
+            }
+        }
+
+        // Configure task dependencies after evaluation
+        project.afterEvaluate {
+            project.tasks.matching {
+                it.name in listOf("preBuild", "build", "assembleDebug", "assembleRelease", "installDebug", "installRelease", "clean")
+            }.configureEach {
+                dependsOn(project.tasks.named("installGitHooks"))
+            }
+        }
+    }
+}

build-logic/convention/src/main/kotlin/org/mifos/GradleManagedDevices.kt

@@ -15,13 +15,13 @@ internal fun configureGradleManagedDevices(
     val pixel6 = DeviceConfig("Pixel 6", 31, "aosp")
     val pixelC = DeviceConfig("Pixel C", 30, "aosp-atd")
 
-    val allDevices = listOf(pixel4, pixel6, pixelC)
+    val localDevices = listOf(pixel4, pixel6, pixelC)
     val ciDevices = listOf(pixel4, pixelC)
 
     commonExtension.testOptions {
         managedDevices {
-            devices {
-                allDevices.forEach { deviceConfig ->
+            allDevices {
+                localDevices.forEach { deviceConfig ->
                     maybeCreate(deviceConfig.taskName, ManagedVirtualDevice::class.java).apply {
                         device = deviceConfig.device
                         apiLevel = deviceConfig.apiLevel
@@ -32,7 +32,7 @@ internal fun configureGradleManagedDevices(
             groups {
                 maybeCreate("ci").apply {
                     ciDevices.forEach { deviceConfig ->
-                        targetDevices.add(devices[deviceConfig.taskName])
+                        targetDevices.add(allDevices[deviceConfig.taskName])
                     }
                 }
             }