Skip to content

Conversation

@obscherler
Copy link

Description

Update frontend-platform to version 8.3.8 in the teak-design-tokens branch to incorporate the following two fixes that affect theming:

8.3.7: Simplify the logic for Paragon fallbackThemeUrl to always rely on window.location?.origin;
8.3.8: Allow the creation of URLs with only brandOverride definition.

How Has This Been Tested?

Theme the MFE with the following config:

MFE_CONFIG["PARAGON_THEME_URLS"] = {
    "core": {
        "urls": {
            "brandOverride": "http://local.edly.io:3000/core.min.css"
        },
    },
    "variants": {
        "light": {
            "urls": {
                "brandOverride": "http://local.edly.io:3000/light.min.css"
            },
        },
    },
}

Prior to the fix, it doesn’t load the CSS.

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

FYI: @brian-smith-tcril

…RL loading.

8.3.7: Simplify the logic for Paragon `fallbackThemeUrl` to always rely on `window.location?.origin`;
8.3.8: Allow the creation of URLs with only `brandOverride` definition.
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 6, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @obscherler!

This repository is currently maintained by @openedx/edx-infinity.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (teak-design-tokens@88bf980). Learn more about missing BASE report.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             teak-design-tokens     #825   +/-   ##
=====================================================
  Coverage                      ?   93.15%           
=====================================================
  Files                         ?      161           
  Lines                         ?     3402           
  Branches                      ?      914           
=====================================================
  Hits                          ?     3169           
  Misses                        ?      216           
  Partials                      ?       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@brian-smith-tcril brian-smith-tcril merged commit e8e5337 into openedx:teak-design-tokens Nov 6, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants