ONVIF motion detection not working with Tapo C545D (and likely other Tapo cameras)

[origin2000]

First of all, thank you for this great project! I’m relatively new to this topic and have spent the last few days learning how to isolate this specific issue. While I am not an ONVIF expert, I’ve documented my findings below and included a suggested fix. As I don't know the ins and outs of the ONVIF specification, I can't judge if the Tapo firmware is violating the standard here. Please evaluate if changing this endpoint globally would cause regressions for other devices

Camera: TP-Link Tapo C545D, Firmware 1.1.15
LightNVR version: 0.31.3 (docker on Rockpi 4C+ running Armbian Linux 6.18.19-current-rockchip64)

Problem 1: Wrong ONVIF service endpoint
The camera exposes all ONVIF services on a single endpoint:
http://camera_ip:2020/onvif/service

LightNVR sends CreatePullPointSubscription to:
http://camera_ip:2020/onvif/events_service ← does not exist

Fix: change "events_service" to "service" in get_subscription()
in src/video/onvif_detection.c

Problem 2: Missing motion event topics
has_motion_event() does not check for Tapo-specific topics.

Camera sends:
tns1:RuleEngine/CellMotionDetector/Motion (IsMotion: true/false)
tns1:RuleEngine/PeopleDetector/People (IsPeople: true/false)

LightNVR checks for:
RuleEngine/MotionDetector ← not sent by Tapo
VideoAnalytics/Motion ← not sent by Tapo
MotionAlarm ← not sent by Tapo

Fix: add "CellMotionDetector", "PeopleDetector",
"IsMotion", "IsPeople" to has_motion_event()

Verified ONVIF Topics via GetEventProperties:
(full XML output available on request)

[matteius]

Just pushed a changeset for this, might help -- do you build locally yet?

[origin2000]

Hi Matteius, thank you so much! No I'm not building locally, yet - honestly need to learn to checkout and setup first ( am old school C guy, just having used local ide, not things like github before). This will certainly take some time to figure it out, but I'll come back with the results.

[origin2000]

I built it locally:

• git clone https://github.com/opensensor/lightNVR.git
• cd lightNVR/
• git submodule update --init --recursive
• docker build -t lightnvr:local .
  Changed the docker-compose.yml: image: lightnvr:local.
  Restarted the container.
  The events of the C545D wide camera that talks ONVIF are being recognized. Videos are now being recorded upon events.
  This is initial feedback. More testing underway.

the URL must be onvif://user:password@192.168.1.123:2020
Not clear as to why I have to reenter credentials & port below, because if the URL is not as shown above credentials &
port below don't make a difference.
Many thanks for the support and changes!

[dpw13]

I think this change may have actually broken ONVIF event subscription for at least my Lorex cameras. For my cameras, the correct endpoint is actually "onvif/event_service" (note the singular event!) rather than the single "onvif/service". Is it possible to detect which endpoints are used, e.g. from GetServices?

Edit: onvif_device_management.c already queries GetServices but only retains the media service. It should be fairly straight-forward to also look for the http://www.onvif.org/ver10/events/wsdl namespace and use the listed XAddr. My cameras don't have it, but I suspect there's also a PTZ service endpoint that can be set as well at the same time.