Skip to content

🐛 Switch to Go1.24 for building#821

Closed
cardil wants to merge 2 commits intoopenshift-knative:mainfrom
cardil:bugfix/1.35/golang-bump
Closed

🐛 Switch to Go1.24 for building#821
cardil wants to merge 2 commits intoopenshift-knative:mainfrom
cardil:bugfix/1.35/golang-bump

Conversation

@cardil
Copy link
Copy Markdown
Member

@cardil cardil commented Oct 24, 2025

Switching to Golang 1.24 as builder for older versions of Go. This is to resolve the problems with calling newer versions of tools from older Go.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Oct 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cardil
Once this PR has been reviewed and has the lgtm label, please assign creydr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cardil
Copy link
Copy Markdown
Member Author

cardil commented Oct 24, 2025

/cc @dsimansk
/cc @creydr
/cc @Kaustubh-pande
/cc @rudyredhat1
/cc @maschmid

@cardil
Copy link
Copy Markdown
Member Author

cardil commented Oct 24, 2025

/hold

@cardil cardil mentioned this pull request Oct 24, 2025
Closed
@dsimansk
Copy link
Copy Markdown
Contributor

dsimansk commented Mar 6, 2026

Superseded by #911 and up-to-date go version 1.25.

/close

@openshift-ci openshift-ci Bot closed this Mar 6, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 6, 2026

@dsimansk: Closed this PR.

Details

In response to this:

Superseded by #911 and up-to-date go version 1.25.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@creydr creydr Awaiting requested review from creydr

@Kaustubh-pande Kaustubh-pande Awaiting requested review from Kaustubh-pande

@dsimansk dsimansk Awaiting requested review from dsimansk

@maschmid maschmid Awaiting requested review from maschmid

@rudyredhat1 rudyredhat1 Awaiting requested review from rudyredhat1

Assignees

No one assigned

Labels

do-not-merge/hold

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cardil @dsimansk