Skip to content

Commit 56fef18

Browse files
committed
Mark notification drawer title for translation
The NotificationDrawerHeader was rendered without a title prop, falling back to PatternFly's hardcoded English "Notifications" string.
1 parent 46a9c16 commit 56fef18

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

frontend/public/components/notification-drawer.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -452,7 +452,10 @@ export const NotificationDrawer: FC<NotificationDrawerProps> = ({
452452

453453
return (
454454
<PfNotificationDrawer ref={drawerRef}>
455-
<NotificationDrawerHeader onClose={toggleNotificationDrawer} />
455+
<NotificationDrawerHeader
456+
title={t('public~Notifications')}
457+
onClose={toggleNotificationDrawer}
458+
/>
456459
<NotificationDrawerBody>
457460
<NotificationDrawerGroupList>
458461
{[criticalAlertCategory, nonCriticalAlertCategory, recommendationsCategory]}

frontend/public/locales/en/public.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1124,6 +1124,7 @@
11241124
"Notifications in the other alerts group": "Notifications in the other alerts group",
11251125
"Recommendations": "Recommendations",
11261126
"Notifications in the recommendations group": "Notifications in the recommendations group",
1127+
"Notifications": "Notifications",
11271128
"No PersistentVolume": "No PersistentVolume",
11281129
"PersistentVolume": "PersistentVolume",
11291130
"Capacity": "Capacity",

0 commit comments

Comments
 (0)