fix: remove duplicate safe_exp function, use exp_safe instead #2265
+1
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #2149
Problem
The codebase has two similar exponentiation functions in
math.rs:exp_safe(line 172): Robust implementation with:max_valuefor positive overflow, 0 for negative)tests/math.rssafe_exp(line 1597): Simple wrapper that:Solution
safe_expfunction frommath.rsrun_epoch.rsto useexp_safeinsteadWhy
exp_safeis bettermax_value(not 0) when large positive inputs would overflow - more mathematically correctTesting
cargo check -p pallet-subtensorpassesexp_safetests intests/math.rsprovide coverage