Skip to content

Conversation

@keithtensor
Copy link
Contributor

Description

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@keithtensor keithtensor requested a review from unconst as a code owner November 19, 2024 16:32
MaxEncodedLen,
scale_info::TypeInfo,
)]
pub enum Mechanism {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe also repr(u8) so we can hint to the compiler that we are never going to add many many more variants?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may not be a good idea since the original type is u16, not u8.

@sam0x17
Copy link
Contributor

sam0x17 commented Nov 22, 2024

looks like e2e failing on a decoding/encoding thing

@keithtensor keithtensor merged commit e84c470 into feat/rao-devnet-ready-2 Nov 22, 2024
9 checks passed
@keithtensor keithtensor deleted the mechanism-enum branch November 22, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants