refactor: remove redundant code

Author: re-taro

crates/oxc_linter/src/generated/rule_runner_impls.rs

@@ -3546,7 +3546,7 @@ impl RuleRunner for crate::rules::unicorn::prefer_date_now::PreferDateNow {
 
 impl RuleRunner for crate::rules::unicorn::prefer_default_parameters::PreferDefaultParameters {
     const NODE_TYPES: Option<&AstTypesBitset> = Some(&AstTypesBitset::from_types(&[
-        AstType::ExpressionStatement,
+        AstType::AssignmentExpression,
         AstType::VariableDeclaration,
     ]));
     const RUN_FUNCTIONS: RuleRunFunctionsImplemented = RuleRunFunctionsImplemented::Run;

crates/oxc_linter/src/rules/unicorn/prefer_default_parameters.rs

@@ -2,7 +2,7 @@ use oxc_ast::{
     AstKind,
     ast::{
         AssignmentOperator, AssignmentTarget, BindingPatternKind, Expression, FormalParameter,
-        LogicalOperator,
+        LogicalOperator, Statement,
     },
 };
 use oxc_diagnostics::OxcDiagnostic;
@@ -86,13 +86,6 @@ fn find_enclosing_function<'a>(
     }
 }
 
-fn get_param_name<'a>(param: &FormalParameter<'a>) -> Option<&'a str> {
-    match &param.pattern.kind {
-        BindingPatternKind::BindingIdentifier(ident) => Some(ident.name.as_str()),
-        _ => None,
-    }
-}
-
 fn has_no_side_effects_before<'a>(
     ctx: &LintContext<'a>,
     node: &AstNode<'a>,
@@ -107,7 +100,13 @@ fn has_no_side_effects_before<'a>(
     let node_span = node.kind().span();
 
     for stmt in &body.statements {
-        if stmt.span() == node_span {
+        let stmt_matches = match stmt {
+            Statement::ExpressionStatement(expr_stmt) => expr_stmt.expression.span() == node_span,
+            Statement::VariableDeclaration(var_decl) => var_decl.span == node_span,
+            _ => stmt.span() == node_span,
+        };
+
+        if stmt_matches {
             return true;
         }
 
@@ -244,7 +243,7 @@ fn check_expression<'a>(
 
     let param_name = param_ident.name.as_str();
 
-    if !&logical_expr.right.get_inner_expression().is_literal() {
+    if !logical_expr.right.get_inner_expression().is_literal() {
         return;
     }
 
@@ -263,9 +262,9 @@ fn check_expression<'a>(
         _ => return,
     };
 
-    let Some((param_index, param)) =
-        params.items.iter().enumerate().find(|(_, p)| get_param_name(p) == Some(param_name))
-    else {
+    let Some((param_index, param)) = params.items.iter().enumerate().find(|(_, p)| {
+        p.pattern.get_binding_identifier().map(|ident| ident.name.as_str()) == Some(param_name)
+    }) else {
         return;
     };
 
@@ -281,10 +280,6 @@ fn check_expression<'a>(
         return;
     }
 
-    if !matches!(param.pattern.kind, BindingPatternKind::BindingIdentifier(_)) {
-        return;
-    }
-
     if !has_no_side_effects_before(ctx, node, function_body_id, param_name) {
         return;
     }
@@ -303,23 +298,20 @@ fn check_expression<'a>(
 impl Rule for PreferDefaultParameters {
     fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) {
         match node.kind() {
-            AstKind::ExpressionStatement(expr_stmt) => {
-                if let Expression::AssignmentExpression(assign_expr) = &expr_stmt.expression {
-                    if assign_expr.operator != AssignmentOperator::Assign {
-                        return;
-                    }
-                    if let AssignmentTarget::AssignmentTargetIdentifier(left_ident) =
-                        &assign_expr.left
-                    {
-                        check_expression(
-                            ctx,
-                            node,
-                            &left_ident.name,
-                            &assign_expr.right,
-                            true,
-                            expr_stmt.span,
-                        );
-                    }
+            AstKind::AssignmentExpression(assign_expr) => {
+                if assign_expr.operator != AssignmentOperator::Assign {
+                    return;
+                }
+                if let AssignmentTarget::AssignmentTargetIdentifier(left_ident) = &assign_expr.left
+                {
+                    check_expression(
+                        ctx,
+                        node,
+                        &left_ident.name,
+                        &assign_expr.right,
+                        true,
+                        assign_expr.span,
+                    );
                 }
             }
             AstKind::VariableDeclaration(var_decl) => {

crates/oxc_linter/src/snapshots/unicorn_prefer_default_parameters.snap

@@ -5,7 +5,7 @@ source: crates/oxc_linter/src/tester.rs
    ╭─[prefer_default_parameters.tsx:2:2]
  1 │ function abc(foo) {
  2 │     foo = foo || 123;
-   ·     ─────────────────
+   ·     ────────────────
  3 │ }
    ╰────
   help: Replace the reassignment with a default parameter.
@@ -14,7 +14,7 @@ source: crates/oxc_linter/src/tester.rs
    ╭─[prefer_default_parameters.tsx:2:2]
  1 │ function abc(foo) {
  2 │     foo = foo || true;
-   ·     ──────────────────
+   ·     ─────────────────
  3 │ }
    ╰────
   help: Replace the reassignment with a default parameter.
@@ -23,7 +23,7 @@ source: crates/oxc_linter/src/tester.rs
    ╭─[prefer_default_parameters.tsx:2:2]
  1 │ function abc(foo) {
  2 │     foo = foo || 123;
-   ·     ─────────────────
+   ·     ────────────────
  3 │     console.log(foo);
    ╰────
   help: Replace the reassignment with a default parameter.
@@ -50,7 +50,7 @@ source: crates/oxc_linter/src/tester.rs
    ╭─[prefer_default_parameters.tsx:2:2]
  1 │ const abc = function(foo) {
  2 │     foo = foo || 123;
-   ·     ─────────────────
+   ·     ────────────────
  3 │ }
    ╰────
   help: Replace the reassignment with a default parameter.
@@ -59,7 +59,7 @@ source: crates/oxc_linter/src/tester.rs
    ╭─[prefer_default_parameters.tsx:2:2]
  1 │ const abc = (foo) => {
  2 │     foo = foo || 'bar';
-   ·     ───────────────────
+   ·     ──────────────────
  3 │ };
    ╰────
   help: Replace the reassignment with a default parameter.
@@ -68,7 +68,7 @@ source: crates/oxc_linter/src/tester.rs
    ╭─[prefer_default_parameters.tsx:2:2]
  1 │ const abc = foo => {
  2 │     foo = foo || 'bar';
-   ·     ───────────────────
+   ·     ──────────────────
  3 │ };
    ╰────
   help: Replace the reassignment with a default parameter.
@@ -86,7 +86,7 @@ source: crates/oxc_linter/src/tester.rs
    ╭─[prefer_default_parameters.tsx:2:2]
  1 │ function abc(foo) {
  2 │     foo = foo || 'bar';
-   ·     ───────────────────
+   ·     ──────────────────
  3 │     bar();
    ╰────
   help: Replace the reassignment with a default parameter.
@@ -95,7 +95,7 @@ source: crates/oxc_linter/src/tester.rs
    ╭─[prefer_default_parameters.tsx:2:2]
  1 │ function abc(foo) {
  2 │     foo = foo ?? 123;
-   ·     ─────────────────
+   ·     ────────────────
  3 │ }
    ╰────
   help: Replace the reassignment with a default parameter.
@@ -122,7 +122,7 @@ source: crates/oxc_linter/src/tester.rs
    ╭─[prefer_default_parameters.tsx:3:3]
  2 │     abc(foo) {
  3 │         foo = foo || 123;
-   ·         ─────────────────
+   ·         ────────────────
  4 │     }
    ╰────
   help: Replace the reassignment with a default parameter.
@@ -131,7 +131,7 @@ source: crates/oxc_linter/src/tester.rs
    ╭─[prefer_default_parameters.tsx:3:3]
  2 │     abc(foo) {
  3 │         foo = foo || 123;
-   ·         ─────────────────
+   ·         ────────────────
  4 │     },
    ╰────
   help: Replace the reassignment with a default parameter.
@@ -140,7 +140,7 @@ source: crates/oxc_linter/src/tester.rs
    ╭─[prefer_default_parameters.tsx:3:3]
  2 │     abc(foo) {
  3 │         foo = foo || 123;
-   ·         ─────────────────
+   ·         ────────────────
  4 │     }
    ╰────
   help: Replace the reassignment with a default parameter.
@@ -149,37 +149,37 @@ source: crates/oxc_linter/src/tester.rs
    ╭─[prefer_default_parameters.tsx:3:3]
  2 │     abc(foo) {
  3 │         foo = foo || 123;
-   ·         ─────────────────
+   ·         ────────────────
  4 │     }
    ╰────
   help: Replace the reassignment with a default parameter.
 
   ⚠ eslint-plugin-unicorn(prefer-default-parameters): Prefer default parameters over reassignment for 'foo'.
    ╭─[prefer_default_parameters.tsx:1:21]
  1 │ function abc(foo) { foo = foo || 'bar'; }
-   ·                     ───────────────────
+   ·                     ──────────────────
    ╰────
   help: Replace the reassignment with a default parameter.
 
   ⚠ eslint-plugin-unicorn(prefer-default-parameters): Prefer default parameters over reassignment for 'foo'.
    ╭─[prefer_default_parameters.tsx:1:21]
  1 │ function abc(foo) { foo = foo || 'bar';}
-   ·                     ───────────────────
+   ·                     ──────────────────
    ╰────
   help: Replace the reassignment with a default parameter.
 
   ⚠ eslint-plugin-unicorn(prefer-default-parameters): Prefer default parameters over reassignment for 'foo'.
    ╭─[prefer_default_parameters.tsx:1:29]
  1 │ const abc = function(foo) { foo = foo || 'bar';}
-   ·                             ───────────────────
+   ·                             ──────────────────
    ╰────
   help: Replace the reassignment with a default parameter.
 
   ⚠ eslint-plugin-unicorn(prefer-default-parameters): Prefer default parameters over reassignment for 'foo'.
    ╭─[prefer_default_parameters.tsx:2:2]
  1 │ function abc(foo) {
  2 │     foo = foo || 'bar'; bar(); baz();
-   ·     ───────────────────
+   ·     ──────────────────
  3 │ }
    ╰────
   help: Replace the reassignment with a default parameter.
@@ -188,7 +188,7 @@ source: crates/oxc_linter/src/tester.rs
    ╭─[prefer_default_parameters.tsx:2:2]
  1 │ function abc(foo) {
  2 │     foo = foo || 'bar';
-   ·     ───────────────────
+   ·     ──────────────────
  3 │     function def(bar) {
    ╰────
   help: Replace the reassignment with a default parameter.
@@ -197,7 +197,7 @@ source: crates/oxc_linter/src/tester.rs
    ╭─[prefer_default_parameters.tsx:4:3]
  3 │     function def(bar) {
  4 │         bar = bar || 'foo';
-   ·         ───────────────────
+   ·         ──────────────────
  5 │     }
    ╰────
   help: Replace the reassignment with a default parameter.
@@ -206,7 +206,7 @@ source: crates/oxc_linter/src/tester.rs
    ╭─[prefer_default_parameters.tsx:4:3]
  3 │     function def(bar) {
  4 │         bar = bar || 'foo';
-   ·         ───────────────────
+   ·         ──────────────────
  5 │     }
    ╰────
   help: Replace the reassignment with a default parameter.
@@ -224,7 +224,7 @@ source: crates/oxc_linter/src/tester.rs
    ╭─[prefer_default_parameters.tsx:3:3]
  2 │     abc(foo) {
  3 │         foo = foo || 123;
-   ·         ─────────────────
+   ·         ────────────────
  4 │     },
    ╰────
   help: Replace the reassignment with a default parameter.
@@ -233,7 +233,7 @@ source: crates/oxc_linter/src/tester.rs
    ╭─[prefer_default_parameters.tsx:6:3]
  5 │     def(foo) {
  6 │         foo = foo || 123;
-   ·         ─────────────────
+   ·         ────────────────
  7 │     }
    ╰────
   help: Replace the reassignment with a default parameter.
@@ -242,7 +242,7 @@ source: crates/oxc_linter/src/tester.rs
    ╭─[prefer_default_parameters.tsx:3:3]
  2 │     abc(foo) {
  3 │         foo = foo || 123;
-   ·         ─────────────────
+   ·         ────────────────
  4 │     }
    ╰────
   help: Replace the reassignment with a default parameter.
@@ -251,7 +251,7 @@ source: crates/oxc_linter/src/tester.rs
    ╭─[prefer_default_parameters.tsx:6:3]
  5 │     def(foo) {
  6 │         foo = foo || 123;
-   ·         ─────────────────
+   ·         ────────────────
  7 │     }
    ╰────
   help: Replace the reassignment with a default parameter.
@@ -260,7 +260,7 @@ source: crates/oxc_linter/src/tester.rs
    ╭─[prefer_default_parameters.tsx:3:2]
  2 │     const noSideEffects = 123;
  3 │     foo = foo || 123;
-   ·     ─────────────────
+   ·     ────────────────
  4 │ }
    ╰────
   help: Replace the reassignment with a default parameter.
@@ -269,7 +269,7 @@ source: crates/oxc_linter/src/tester.rs
    ╭─[prefer_default_parameters.tsx:5:2]
  4 │ 
  5 │     foo = foo || 123;
-   ·     ─────────────────
+   ·     ────────────────
  6 │     console.log(foo);
    ╰────
   help: Replace the reassignment with a default parameter.
@@ -278,7 +278,7 @@ source: crates/oxc_linter/src/tester.rs
    ╭─[prefer_default_parameters.tsx:3:2]
  2 │     const bar = function() {};
  3 │     foo = foo || 123;
-   ·     ─────────────────
+   ·     ────────────────
  4 │ }
    ╰────
   help: Replace the reassignment with a default parameter.