Skip to content

Commit 7162d03

Browse files
re-tarocamc314
authored andcommitted
feat(linter): add unicorn/prefer-default-parameters rule (#16620)
This PR adds unicorn/prefer-default-parameters rule, issue #684 [rule doc](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v62.0.0/docs/rules/prefer-default-parameters.md) [rule source](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v62.0.0/rules/prefer-default-parameters.js) --------- Co-authored-by: Cameron Clark <[email protected]>
1 parent 14b65d3 commit 7162d03

File tree

4 files changed

+1180
-0
lines changed

4 files changed

+1180
-0
lines changed

crates/oxc_linter/src/generated/rule_runner_impls.rs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3544,6 +3544,14 @@ impl RuleRunner for crate::rules::unicorn::prefer_date_now::PreferDateNow {
35443544
const RUN_FUNCTIONS: RuleRunFunctionsImplemented = RuleRunFunctionsImplemented::Run;
35453545
}
35463546

3547+
impl RuleRunner for crate::rules::unicorn::prefer_default_parameters::PreferDefaultParameters {
3548+
const NODE_TYPES: Option<&AstTypesBitset> = Some(&AstTypesBitset::from_types(&[
3549+
AstType::AssignmentExpression,
3550+
AstType::VariableDeclaration,
3551+
]));
3552+
const RUN_FUNCTIONS: RuleRunFunctionsImplemented = RuleRunFunctionsImplemented::Run;
3553+
}
3554+
35473555
impl RuleRunner for crate::rules::unicorn::prefer_dom_node_append::PreferDomNodeAppend {
35483556
const NODE_TYPES: Option<&AstTypesBitset> =
35493557
Some(&AstTypesBitset::from_types(&[AstType::CallExpression]));

crates/oxc_linter/src/rules.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -472,6 +472,7 @@ pub(crate) mod unicorn {
472472
pub mod prefer_classlist_toggle;
473473
pub mod prefer_code_point;
474474
pub mod prefer_date_now;
475+
pub mod prefer_default_parameters;
475476
pub mod prefer_dom_node_append;
476477
pub mod prefer_dom_node_dataset;
477478
pub mod prefer_dom_node_remove;
@@ -1221,6 +1222,7 @@ oxc_macros::declare_all_lint_rules! {
12211222
unicorn::prefer_classlist_toggle,
12221223
unicorn::prefer_class_fields,
12231224
unicorn::prefer_bigint_literals,
1225+
unicorn::prefer_default_parameters,
12241226
unicorn::prefer_response_static_json,
12251227
unicorn::prefer_top_level_await,
12261228
unicorn::prefer_at,

0 commit comments

Comments
 (0)