Skip to content

Conversation

@KapJI
Copy link

@KapJI KapJI commented Nov 30, 2023

Replace os.path.normpath with str(pathlib.Path()) which correctly fixes path separators when UNC path is provided.

Tested that this code doesn't escape search dir, e.g.:

>>> str(pathlib.Path(posixpath.join("C:\\abc", "e:d\\ef")))
'C:\\abc\\e:d\\ef'
>>> str(pathlib.Path(posixpath.join("\\\\?\\C:\\abc", "e:d\\ef")))
'\\\\?\\C:\\abc\\e:d\\ef'

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Faulty handling of UNC paths

1 participant