Skip to content

Bug - ModalFooter - Wrapping a Button in a ModalFooter with a Tooltip changes margins #12534

Description

@mvollmer

We have a button in a ModalFooter that might be disabled and then has a Tooltip to explain the reason. The Button has a wrong margin-inline-end style when it has a Tooltip.

Without theTooltip:

Image

With the Tooltip:

Image

You can see that the "Cancel" button has moved to the left a bit and is now touching the "Create and edit" button.

The code is something like this:

...
<ModalFooter>
  <Button>Create and run</Button>
  <Tooltip content={...}><Button isAriaDisabled>Create and edit</Button></Tooltip>
</ModalFooter>

There is some CSS somewhere that gives the Buttons in a ModalFooter a margin-inline-end value of 8px. This CSS however only applies to Buttons that are directly in a ModalFooter. It will be ignored for the Button wrapped in a Tooltip.

(Since the ModalFooter is a flex anyway, I would expect the button spacing to be handled by the column-gap of that, and not by margin manipulations, but maybe that doesn't work for some reason.)


Jira Issue: PF-4411

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions